Repository navigation
fix: keep pages usable without WebGL2 - #26
Merged
Merged
Conversation
The whole app rendered a blank page on browsers/configs that disable
WebGL (e.g. Librewolf's per-domain allow list). new Canvas() ran during
the synchronous SolidJS render and GLContext threw "WebGL2 not supported"
when getContext("webgl2") returned null, aborting the entire render —
even pages that don't need WebGL.
Canvas now catches the failure, exposes a `supported` flag, and guards
all GL operations so the decorative background simply doesn't render.
The room (which needs WebGL for video) is gated behind canvas.supported
and shows a clear "WebGL is required" notice instead of a blank page.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 53 minutes. View limit details
Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
kixelated
disabled auto-merge
November 7, 2026 17:13
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Without WebGL2, canvas initialization aborts the page render. Guarding only the global background still leaves the About demo and profile preview constructing WebGL renderers.
Approach
Detect a missing WebGL2 context during setup, before creating a renderer. Keep the About content and profile controls available while their previews show an unsupported message. Show the room requirement before creating its connection, capture, or audio graph. Genuine shader and renderer errors still throw. Merge the current main branch.
Impact
Application behavior only; no published package API or wire changes. Supported browsers retain the existing renderer. The optional demo now closes its canvas and sound resources on disposal.
Alternatives
Keep the existing WebGL renderer and gate its consumers at initialization. A second renderer would add a separate rendering path.
Follow-ups
The existing Quest/MoQ migration supplies the missing Rust toolchain described below; no duplicate tooling change is included here.
Validation
quest gate just buildin the repository's Nix shell: passed.API/app TypeScript, Biome and both metadata tests: passed. One existing updater lint warning remains.
Real Chromium with WebGL2 disabled:
/,/about,/homeand/@testrender their intended content without page errors; microphone and camera controls remain present on Home. Before the demo guard, both About routes reproduced blank pages withWebGL2 not supported.Full
just checkexits 1 at native formatting withmbx[error]: could not find the real Cargo after excluding /home/kixelated/.local/share/mbx/bin/cargo. The unchanged base 171ed63 fails identically after the JS checks and tests pass. Both runs usednix develop --accept-flake-config --command /nix/store/5gdm9zz9rz8dmb3zlnn0rhh7dwqnaaw4-quest-0.1.0/bin/quest gate just check.Supported WebGL rendering and native app compilation were not exercised on this host.
Required GitHub Check: passed on the reviewed head.
Pre-queue Quest validation was invoked against both this head and unchanged main; both report
ENOENTforquest/. Neither Git tree contains a quest directory yet, so there are no quest documents to update or invalidate. The migration introduces Quest setup separately.Review
Claude Code /
claude-opus-5-5, medium effort, round 2 reviewed e6cae2e: no findings. Round 1's finding was fixed by keeping media controls and the edit-profile link outside the preview capability guard.Auto-merge was disabled before pushing the reviewed head so the new head is left for the maintainer's existing merge pick.
(Written by GPT-6.1 Sol with xhigh)