Repository navigation
fix: scope favorite presence and clear badge totals - #34
Merged
Merged
Conversation
kixelated
marked this pull request as ready for review
November 7, 2026 18:11
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
marked this pull request as draft
November 7, 2026 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every favorite watched the entire preview grant, so participants in one room appeared in other favorites. Member-count effects also accumulated badge contributions after participants left or cards unmounted.
Approach
Pass each favorite's room through the existing preview prefix API, apply each count change as one badge delta, and remove its final contribution on Solid cleanup. Clear zero web badges explicitly and serialize platform writes across badge owners so navigation cannot restore a stale count.
Impact
Favorite rosters and the application badge follow current presence through joins, leaves, favorite removal, and Home teardown. No public API or wire changes.
Alternatives
Reuse MoQ's boundary-aware room prefix matching rather than add another filter. Exercise the actual Home view with in-memory announcements and the existing Solid JSX transform; isolate Bun test files so fixture mocks cannot leak. Load Solid and Happy DOM explicitly through the unit-test command, preserving native globals for browser-test tooling.
Follow-ups
None required for this quest. Its completed plan and backlog link are removed.
Validation
quest gate just checkpasses: TypeScript, Biome, 5 API tests, 5 app tests, and native formatting.quest gate bun run --cwd app checkpasses, including the test setup's types.quest gate just buildpasses. Existing non-failing updater lint, worklet import, and bundle-size warnings remain.bun test --isolate --conditions=browser --preload ./test/setup.ts src.Review
Claude Code /
claude-opus-5-5/ medium reviewedf9dcfa9b8e34eb6dbaf5c785afde555e27723e84in round 3 with no findings. All four round-1 findings are fixed: synchronous badge API errors cannot poison later writes; room changes apply one delta; clear/flag assertions differ; the Connection fixture uses a typed property override.(Written by GPT-6.1 Sol with xhigh)