Repository navigation
ci: add the Pullfrog workflow for PR reviews #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # PULLFROG ACTION - DO NOT EDIT EXCEPT WHERE INDICATED | ||
| name: Pullfrog | ||
| run-name: ${{ inputs.name || github.workflow }} | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| prompt: | ||
| type: string | ||
| description: Agent prompt | ||
| name: | ||
| type: string | ||
| description: Run name | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| pullfrog: | ||
| runs-on: ubuntu-latest | ||
| # Only main may deploy to this environment, so a dispatch on a pushed | ||
| # branch can't mint the OIDC token Pullfrog trades for model access. | ||
| environment: pullfrog | ||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| fetch-depth: 1 | ||
| persist-credentials: false | ||
| - name: Run agent | ||
| uses: pullfrog/pullfrog@0741f79ecebfa4469a010644d2aed2d96d32d489 # v0.1.127 | ||
| with: | ||
| prompt: ${{ inputs.prompt }} | ||
| # No provider keys from this repository: model access is configured | ||
| # in the Pullfrog console (https://docs.pullfrog.com/model-access). | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set
push: disabledfor this review workflow.The
with:block omitspush, so the action uses its default,enabled. With that value, Pullfrog mints an installation token that carriescontents: writeandworkflows: writefor git operations. The job-levelcontents: readdoes not limit that token. The agent can therefore push to repository branches and change workflow files, which contradicts the stated read-only scope of this workflow.Set
push: disabledso the git token hascontents: readonly.Suggested fix
Committable suggestion
Source: Learnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed: reviews need no git push. Pullfrog's
pushsetting is nowdisabledfor this repository (and the other quest repositories getting this workflow), so the run's git token is read-only. I kept the workflow file identical to the others rather than pinning it inwith:.(Written by Opus 5.5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis chain
Script executed:
Length of output: 5120
web_search executed:
For Pullfrog GitHub Action version v0.1.127, how does the action'spushinput interact with the Pullfrog console repository-levelpushsetting? In particular, can the console setting disable push and produce a read-only git token when the workflow omitspushand the action input defaults to enabled? Find official documentation or source.Length of output: 14398
Script executed:
Length of output: 20648
Script executed:
Length of output: 3586
Script executed:
Length of output: 10947
@kixelatedI was wrong to say that omittingpushalways selectsenabled. The pinned action uses the repository setting when the workflow input is absent.If that setting is
disabled, the action requests a read-only git token. I could not independently verify the repository setting. Please verify it before merge and check the git token permissions on the first run. I’m not marking the finding as addressed yet.Learnings added
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
You are interacting with an AI system.