Skip to content

moq-cli play does not compile on dev: latency_max fields renamed under it #2778

Closed

Description

@kixelated

cargo check -p moq-cli --all-features fails on current dev (0bde6b1):

error[E0609]: no field `latency_max` on type `moq_video::decode::Config`
   --> rs/moq-cli/src/play.rs:279
error[E0609]: no field `latency_max` on type `moq_audio::decode::Config`
   --> rs/moq-cli/src/play.rs:311

Mechanism: #2697 (moq play, merged from main via the af7b572 criss-cross merge) sets decode.latency_max = Some(self.args.latency_max) on the video and audio decode configs, but dev's #2688 standardized those configs on a latency: Latency field (available fields: kind, latency, resize / format, sample_rate, channels, latency). The two sides never compiled together: the play feature is only built by just ci's --all-features pass, and pushes to dev skip the Check workflow, so the break surfaced only on the next PR's CI (#2736, which touches none of these crates).

Fix shape: convert the CLI's Duration arg through the Latency type (moq_mux::Latency/moq_net::Latency max semantics) at both call sites, and consider whether play's arg should now be named/plumbed per #2688's convention.

This is the second dev-only break surfaced by #2736's CI (the first was #2763); together they suggest dev pushes deserve at least a compile-only Check run.

(written by Fable 5)

Activity

  1. coderabbitai commented on Aug 12, 2026

    @coderabbitai
    Contributor
    🔗 Related PRs

    #1023 - Rename moq binary to moq-cli [closed]
    #1782 - fix(ci): unbreak the self-hosted A1 runner (libmoq clippy + ffmpeg bindgen headers) [merged]
    #2462 - build(rust): pin the toolchain and correct the MSRV claims [merged]
    #2669 - fix(libmoq): unbreak the Linux C link list, and make VAAPI opt-in [merged]
    #2679 - fix(moq-mux): make the synthesized fMP4 init playable on strict players [merged]
    #2697 - feat(cli): add moq play [merged]


    📝 Issue Planner

    Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.

    • Create Plan

    🧪 Issue enrichment is currently in open beta.

    You can configure auto-planning by selecting labels in the issue_enrichment configuration.

    To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

    issue_enrichment:
      auto_enrich:
        enabled: false

    💬 Have feedback or questions? Drop into our discord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions