Skip to content

moq-lite-06: a publisher at Probe level Report resets the Probe Stream on the subscriber's first PROBE target #5258

Closed

Description

@mondain

Problem

A moq-lite-06 publisher that advertised Probe level Report resets the Probe Stream as soon as the subscriber sends its first PROBE target, instead of treating the target as input and reporting.

Draft (section 5.1.5): "The subscriber sends a PROBE message with a target bitrate on the bidirectional stream. The subscriber MAY send additional PROBE messages on the same stream to update the target bitrate; the publisher MUST treat each PROBE as a new target to attempt." A publisher that advertised Report but not Increase "ignores the target and only reports"; resetting the stream is for a publisher that advertised no Probe capability.

Repro

  1. Connect to moq (publisher) over moq-lite-06; its SETUP advertises Probe level Report (parameter 1 = 01).
  2. Open a Probe Stream (bidirectional, stream type 0x4) and send one target: 04 05 80 3d 09 00 00 (target 4 000 000 bit/s, RTT 0).
  3. About 1 ms later the CLI logs WARN moq_net::lite::publisher: probe stream error err=short buffer, resets the stream with MALFORMED_TRACK (0x12), sends STOP_SENDING 0, and keeps the session open. No report is ever sent.

Verified on moq 0.14.2 from main at 954505e and on 0.14.1 at b8b0d23, on native QUIC and WebTransport.

Where

rs/moq-net/src/lite/publisher.rs: ProbeServe::poll_probe never decodes what the subscriber writes. It polls stream.reader.poll_closed, which accepts only a FIN, so the first byte of a target message is a read error that ends the stream. rs/moq-net/src/lite/probe.rs can decode the message but is not used on this path.

Suggested fix

Read PROBE messages the subscriber writes as targets (the value is ignored at Report level) and keep reporting; only a FIN or reset from the subscriber ends the stream.


Found with an interop runner (mondain/moq-contribution-interop-runner, docs/moq-lite-punch-list.md item ML-04; row L06-5-1-5-MUST-072). Drafted with AI assistance; the bytes and logs above are from real runs.

Activity

  1. added
    questBeing tracked/planned in a quest. See `quest/`
    on Oct 12, 2026
  2. kixelated commented on Oct 12, 2026

    @kixelated
    Collaborator

    Confirmed in Rust, and in js/net too where it applies. We're fixing #5257, #5258 and #5259 together in one quest, quest/m1/lite-malformed-close.md, planned in #5358. Decisions:

    • SETUP: a client closes with PROTOCOL_VIOLATION on Path or Role in the server's SETUP. A server also closes on Path over a binding whose handshake carries a URI.
    • PROBE: a Report-level publisher decodes PROBE targets and keeps reporting. Only a FIN or a reset ends the stream.
    • Control streams: any decode error on a control stream closes the session with PROTOCOL_VIOLATION, not just the two cases cited. This includes child handlers and response decoders on streams we opened. Data-stream decode errors stay per-stream.

    The rules are the same from lite-06 through lite-07-wip, so the fix covers every lite version. Thanks for the precise byte-level repros.

    Anyone who wants to donate tokens can run /quest-start quest/m1/lite-malformed-close.

    (Written by Claude Opus 5.5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questBeing tracked/planned in a quest. See `quest/`

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions