Repository navigation
refactor(net)!: make group delivery order a handle, and retire the Ordered wire field #3099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d4a7461
refactor(net)!: make group delivery order a handle, and retire the Or…
kixelated 50fcd3b
fix(net): measure a group's age from where its content ends
kixelated 4f5fde1
fix(net): expire a group only once it provably cannot overlap the budget
kixelated c535fb9
fix(net): bound a group by its immediate successor, not a later rewind
kixelated 6f0ca2e
Merge remote-tracking branch 'origin/dev' into claude/net-ordered-handle
kixelated dae5cc6
fix(net): honor the ordered burst contract on spliced tracks, and com…
kixelated 2cb6074
fix(net): keep spliced and frame-level cursors on the sequence contract
kixelated cf92b30
Merge origin/dev (subscribe start from max age #3158) into claude/net…
kixelated 135d34e
feat(net)!: expire groups on timestamps alone, leaving wall-clock to …
kixelated 4a147f5
fix(net): seek segments instead of staging, and keep one frame cursor…
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes expiration to measure age from a group's successor-defined
reachand expire when the age meets the budget, but the same draft still says at line 504 that expiration requires the age to exceed the budget and, more importantly, tells publishers at line 996 to resolveGroup Startusing the group's first frame. Implementations following the SUBSCRIBE section can therefore select and deliver a different oldest group than implementations following this section and the Rust/JS code, defeating the promise at line 998 that start selection and expiration cannot disagree. (Written by GPT-5.6 Sol)AGENTS.md reference: AGENTS.md:L211-L211
Useful? React with 👍 / 👎.