Repository navigation
quest: review the unreviewed quests from 2026-09-05 to 09-08 #3541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,42 @@ | ||
| # [M] Cover denied capture permission in the browser | ||
| # [M] moq-publish surfaces a capture denial and recovers when permission is granted | ||
|
|
||
| ## Goal | ||
|
|
||
| The browser harness proves what `<moq-publish>` does when the user refuses the | ||
| camera or microphone: no broadcast is announced, the failure is visible through | ||
| the public API, and a subscriber gets a clean "nothing is published" rather than | ||
| a hang or a half-announced broadcast. Granting permission afterwards recovers | ||
| without a reload. | ||
| When the user refuses the camera or microphone, `<moq-publish>` says so | ||
| through its public state, announces no broadcast, and a subscriber sees a | ||
| clean "nothing is published" rather than a hang or a half-announced | ||
| broadcast. Granting permission afterwards recovers without a reload. The | ||
| browser harness proves all of it. | ||
|
|
||
| ## Plan | ||
|
|
||
| `test/smoke/clients/js/media.ts` already runs Chromium without | ||
| `--use-fake-ui-for-media-stream` and asserts the user-gesture gate on audio, but | ||
| every media case it drives uses the generated fixture, which never calls | ||
| `getUserMedia`. The permission path is still only exercised by the interop | ||
| matrix, which grants everything up front. | ||
| Today a denial is invisible. `js/publish/src/source/camera.ts` swallows the | ||
| `getUserMedia` rejection (`.catch(() => undefined)`) and hands it to the | ||
| retry loop; `microphone.ts` does the same, `device.ts` only warns. `Camera.out` | ||
| exposes `source` alone and `Retry` has no public failure signal, so the only | ||
| external symptom is a `source` that never becomes defined. | ||
|
|
||
| - Drive `<moq-publish source="camera">` in a context where capture is denied. | ||
| `--use-fake-device-for-media-stream` keeps the device deterministic while | ||
| Playwright's permission state decides the verdict, so the case stays | ||
| repeatable. | ||
| - Assert `announce="source"` holds the broadcast back, that the element surfaces | ||
| the denial through its public state rather than only a console warning, and | ||
| that a subscriber sees no announcement. | ||
| - Grant the permission and assert the broadcast announces and encodes without | ||
| reloading the page. | ||
| - Publish what the case cannot claim: a fake device is not a real one, and a | ||
| headless permission decision is not a user clicking a prompt. | ||
| - Assert the audio gesture gate while there. `media.ts` clicks both pages and | ||
| requires audio afterwards, but does not assert silence beforehand: Chromium | ||
| enforces the gate on the fixture page and has been seen not enforcing it on the | ||
| player's, whose graph is built a second later. Find what actually decides it, | ||
| then assert the gate rather than only exercising it. | ||
| - Give the capture sources a public failure state: the denial (and any other | ||
| terminal `getUserMedia` error) reaches `<moq-publish>` as an observable | ||
| status a page can render, and the element stops retrying a permission the | ||
| user refused. Refused is refused; a silent retry loop is warn-then-ignore. | ||
|
Comment on lines
+19
to
+22
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🤖 get_repo_knowledge executed:
Length of output: 32484 🏁 Script executed: #!/bin/bash
set -eu
file=$(git ls-files 'quest/m0/browser-permission-qa.md')
printf '%s\n' "$file"
sed -n '1,80p' "$file"
printf '\n--- related permission/recovery references ---\n'
rg -n -i 'permission|capture|getUserMedia|retry|recover|grant|moq-publish' quest --glob '*.md' | head -200Repository: moq-dev/moq Length of output: 30241 Specify the recovery trigger for When the refusal path stops capture retries, define how 🤖 Prompt for AI Agents |
||
| - Keep `announce="source"` holding the broadcast back while there is no | ||
| source, so a subscriber sees no announcement. | ||
| - Regression in `test/smoke/clients/js/media.ts`: drive | ||
| `<moq-publish source="camera">` with `--use-fake-device-for-media-stream` | ||
| so the device is deterministic while Playwright's permission state decides | ||
| the verdict. Assert the denial is visible through the element's state, no | ||
| announcement reaches the subscriber, then grant the permission and assert | ||
| the broadcast announces and encodes without reloading the page. State what | ||
| the case cannot claim: a fake device is not a real one and a headless | ||
| permission decision is not a user clicking a prompt. | ||
| - Assert the audio gesture gate while there. `media.ts` clicks both pages | ||
| and requires audio afterwards but does not assert silence beforehand; | ||
| Chromium enforces the gate on the fixture page and has been seen not | ||
| enforcing it on the player's, whose graph is built a second later. Find | ||
| what decides it, then assert the gate rather than only exercising it. | ||
|
|
||
| ## Related | ||
|
|
||
| - [Publisher audio unlock](/quest/m0/publish-audio-unlock.md) - the other publisher path that fails silently without a gesture | ||
| - [Failure artifacts](/quest/m0/qa-failure-artifacts.md) - shared trace and sample output | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # [S] Trim what rode in with the harness isolation | ||
|
|
||
| ## Goal | ||
|
|
||
| The test harness isolation from #3509 keeps its point (private run | ||
| directories, reserved ports, process-group teardown) and sheds the two | ||
| things that came along without a reason to live in this repository: the | ||
| `just worktree` recipe and, if nobody reads it, the `kind` field on the | ||
| relay's `listening` log line. | ||
|
|
||
| ## Plan | ||
|
|
||
| - Delete the `worktree` recipe and its helpers from the root `justfile` | ||
| (about 265 lines: metadata-access probing, base recording, staleness | ||
| reports) and the section of `test/README.md` that documents it. Keep the | ||
| `_base` split that `_changed` shares, since `just check` scopes with it. | ||
| - Decide whether the relay's `kind = "quic" | "http" | "https"` on the | ||
| `listening` line and the two new web-listener lines stay. They are | ||
| operator-visible and documented in `doc/bin/relay/config.md`; keep them | ||
| only if the harness actually reads the bound address from them, otherwise | ||
| revert to the single line and drop the doc. | ||
|
Comment on lines
+17
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Deciding whether to retain the relay's operator-visible listener records is independently completable from deleting the worktree recipe and touches different product behavior, documentation, and tests. Keeping both in this quest would make its implementation PR mix an unrelated relay logging change into harness-tool cleanup; move this decision to its own quest. quest/CLAUDE.mdL99-L101 Useful? React with 👍 / 👎. |
||
| - `just clean` staying this-checkout-only is fine; leave it. | ||
|
|
||
| ## Related | ||
|
|
||
| - [Failure artifacts](/quest/m0/qa-failure-artifacts.md) - the harness run directory this trims around | ||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Cover every stated acceptance criterion.
The Goal requires a LAN run and no skip-aheads in steady state. The browser step checks only underruns for a local TS import, and the manual step names only the public relay. Add an explicit LAN run and a skip-ahead assertion, or remove these requirements from the Goal. Otherwise, the quest can pass with two stated requirements unverified.
Also applies to: 24-27, 31-32
🤖 Prompt for AI Agents