Repository navigation
feat(cli): accept several adaptive import stages on one connection - #3578
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b321075a39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
PR #3578 — feat(cli): accept several adaptive import stages on one connection
SummaryRemoves the CLI ensure that refused more than one bandwidth-adaptive FindingsBlockersNone. Risks
NitsNone. Quest markdown cleanup is fine. CI
VerdictApprove — merge anytime; good early batch candidate with #3584. |
The connection allocator already divides the estimate among encoding stages, so two import capture stages on --connect are valid. Co-Authored-By: grok-4.6 <noreply@x.ai>
b321075 to
8937868
Compare
Summary
--connectclient. The connection's bandwidth allocator already divides the estimate among encoding stages by track priority, so twoimport capturestages are valid.ImportSource::uses_bandwidth, which had no remaining readers.Closes #2815.
Public API
moq --connect <url> import capture -- import captureis accepted. The error "a stage that encodes to fit the connection's bandwidth estimate assumes it's the only publisher..." is gone.Wire
None.
(written by grok-4.6)