Skip to content

feat(cli): accept several adaptive import stages on one connection - #3578

Merged
kixelated merged 2 commits into
devfrom
quest/m1/2815-lift-adaptive-stage-refusal
Sep 12, 2026
Merged

kixelated merged 2 commits into
devfrom
quest/m1/2815-lift-adaptive-stage-refusal

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the CLI refusal that required an adaptive capture to be the only import on a --connect client. The connection's bandwidth allocator already divides the estimate among encoding stages by track priority, so two import capture stages are valid.
  • Drop ImportSource::uses_bandwidth, which had no remaining readers.
  • Keep the unstageable-verb check.

Closes #2815.

Public API

  • CLI: moq --connect <url> import capture -- import capture is accepted. The error "a stage that encodes to fit the connection's bandwidth estimate assumes it's the only publisher..." is gone.

Wire

None.

(written by grok-4.6)

@kixelated
kixelated marked this pull request as ready for review September 10, 2026 07:07
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-12T05:16:22.992424Z 8937868 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b321075a39

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rs/moq-cli/src/args.rs Resolved
@kixelated

Copy link
Copy Markdown
Collaborator Author

Disclaimer: This review was posted by Grok Bot (an automated assistant), not a human reviewer. Treat findings as advisory — verify before acting.

PR #3578 — feat(cli): accept several adaptive import stages on one connection

Summary

Removes the CLI ensure that refused more than one bandwidth-adaptive import capture on a single --connect client. The connection bandwidth allocator already divides the estimate by track priority, so multiple adaptive stages are valid. Deletes dead ImportSource::uses_bandwidth and its tests; keeps the unstageable-verb check. Closes #2815.

Findings

Blockers

None.

Risks

  1. Behavioral: users can now run multi-capture adaptive pipelines that previously erred. Load on the allocator / priority fairness under two heavy encodes is the only runtime risk — out of scope for this PR if the allocator contract is trusted (as stated).
  2. Tiny touch on rs/moq-cli/src/args.rs — mild overlap with feat(relay): merge config with recorded provenance #3587’s cli Cargo/settings work but not the same logic; low conflict risk.

Nits

None. Quest markdown cleanup is fine.

CI

Check Result
Check SUCCESS
Test SUCCESS

Verdict

Approve — merge anytime; good early batch candidate with #3584.

kixelated and others added 2 commits September 11, 2026 22:04
The connection allocator already divides the estimate among encoding
stages, so two import capture stages on --connect are valid.

Co-Authored-By: grok-4.6 <noreply@x.ai>
@kixelated
kixelated force-pushed the quest/m1/2815-lift-adaptive-stage-refusal branch from b321075 to 8937868 Compare September 12, 2026 05:14
@kixelated
kixelated enabled auto-merge (squash) September 12, 2026 05:14
@kixelated
kixelated merged commit 100e8f8 into dev Sep 12, 2026
4 checks passed
@kixelated
kixelated deleted the quest/m1/2815-lift-adaptive-stage-refusal branch September 12, 2026 05:20
@moq-bot moq-bot Bot mentioned this pull request Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant