Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions quest/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,22 @@ grouped into milestones ordered by priority.

## Plan

Milestones sort by kind, which tracks urgency here: m0 fixes what is broken,
Milestones sort by kind, which tracks urgency here: m0 blocks the release,
m1 is the dev branch line, m2 grows the surface, m3 explores. The 2026-08
grooming turned every surviving GitHub issue into a quest and migrated the
upstream-facing questlines from the downstream moq.pro tree; issues opened
since are imported in periodic grooming passes (the last one on 2026-09-05),
and an issue already fixed on `dev` stays open until `dev` merges. New work joins the milestone matching its
kind, at its priority rank.
and an issue already fixed on `dev` stays open until `dev` merges. The
2026-09-12 pass narrowed m0 to the release blockers and moved every additive
dev quest to m2. New work joins the milestone matching its kind, at its
priority rank.

## Quests

- [m0: bug fixes](/quest/m0/README.md) - defects in what main ships today,
security first
- [m0: release blockers](/quest/m0/README.md) - what must land before dev
merges and the release is cut
- [m1: the dev line](/quest/m1/README.md) - the breaking API and wire
changes, the archive line that gates the dev merge, and the merge itself
changes, the merge gates, and the merge itself
- [m2: features](/quest/m2/README.md) - new capabilities on stable surfaces,
from wire extensions to E2EE to developer packages
- [m3: prototypes](/quest/m3/README.md) - experiments, spikes, hardware
Expand Down
37 changes: 0 additions & 37 deletions quest/m0/3492-ietf-track-status-refusal.md

This file was deleted.

67 changes: 43 additions & 24 deletions quest/m0/3532-connect-auth-race.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,12 @@

## Goal

`moq_native::Client::connect` against a WebTransport-only endpoint succeeds
`moq_tokio::Client::connect` against a WebTransport-only endpoint succeeds
whenever the QUIC dial succeeds, even when the WebSocket fallback is refused
first. Cloudflare's relays answer every non-WebTransport request with 403, and
today that 403 landing inside the 200 ms fallback delay fails the whole connect
as Forbidden while the QUIC arm is still in flight, indistinguishable from a bad
token. An auth error ends the race only when the other arm has also failed, and
a moq-ffi caller can disable the WebSocket fallback the way libmoq and the CLI
already can.
token. An auth error ends the race only when the other arm has also failed.

Boundaries: blind subscription, consuming a broadcast the peer never announced,
stays refused. A client here may hold several connections and cannot pick one
Expand All @@ -19,27 +17,48 @@ non-conformant, not a gap in this repo.

## Plan

- `race_transport_connect` in `rs/moq-native/src/client.rs` returns on
`err.is_auth()` from either arm. Record an auth error like any other failure
and keep polling the other arm. When both are done, the result is an auth
error only if both arms rejected authentication; otherwise report the
non-auth failure, which stays retryable, because `Reconnect::run` exits on
`is_auth()` and a fallback endpoint that answers every non-WebTransport
request with 403 must not stop the client from retrying a QUIC dial that
merely failed transiently. Flip
`race_transport_connect_stops_on_quic_auth_error` and add: WebSocket 403 then
QUIC success connects; both arms refusing reports Forbidden; a transient QUIC
failure after a WebSocket 403 reports the QUIC error and the reconnect loop
retries.
- `MoqClient` in `rs/moq-ffi/src/session.rs` gains `set_websocket_enabled` and
`set_websocket_delay` beside `set_tls_disable_verify`, mapping onto
`websocket::Client::{enabled, delay}`. libmoq already exports
`moq_client_set_websocket_enabled` and `_delay`; mirror the two setters in
`py/moq-rs`, `swift`, `kt`, `go/wrapper/moq`, `dart/moq`, and
`doc/lib/{py,swift,kt,go,dart}`.

On main, additive.
Branch from dev: `rs/moq-tokio` exists only there, and main still ships the
deprecated `rs/moq-native`.

`race_transport_connect` (`rs/moq-tokio/src/client.rs:642`) polls both arms
in a `select!` loop. Each arm has an early return on `err.is_auth()`: the QUIC
arm at line 660 and the WebSocket arm at line 671. Every other failure is
recorded and the loop keeps polling the other arm, then line 690 folds the
pair: both failed is `Error::TransportRace`, one failed is that error, neither
ran is `ConnectFailed`. `connect_inner` calls it at line 564 with the
WebSocket arm from `websocket::race_handle` (`rs/moq-tokio/src/websocket.rs:228`),
which yields `None` when the fallback is disabled and otherwise dials after the
configured head start, so a fast 403 is what lands first.

- Delete both `is_auth()` early returns. An auth error is recorded like any
other failure and the loop continues until both arms are done.
- Fold the pair with auth awareness: the result is an auth error only when
both arms rejected authentication. When one arm is auth and the other is a
non-auth failure, report the non-auth failure, which stays retryable. This
matters because the reconnect loop treats `is_auth()` as terminal at
`rs/moq-tokio/src/connection.rs:759` and `:810`; a fallback endpoint that
refuses every non-WebTransport request must not stop the client from
redialing a QUIC arm that merely failed transiently.
- Keep `TransportRace` for the both-non-auth case so the log still names
both failures.

Tests, all in the `client.rs` test module beside the existing three:

- Flip `race_transport_connect_stops_on_quic_auth_error` (line 1228): a QUIC
`Unauthorized` followed by a WebSocket success now connects over WebSocket.
- WebSocket 403 (`ConnectError::Forbidden` or the status mapping in
`rs/moq-tokio/src/connect.rs:366`) then QUIC success connects over QUIC.
- Both arms refusing reports an auth error.
- WebSocket 403 then a transient QUIC failure reports the QUIC error, and
`err.is_auth()` is false so `Reconnect` retries.
- `race_transport_connect_keeps_websocket_after_quic_non_auth_error` (1242)
and `race_transport_connect_returns_when_quic_transport_connects` (1252)
pass unchanged.

## Closes

- [#3532](https://github.com/moq-dev/moq/issues/3532) - close this issue when the quest finishes

## Related

- [FFI WebSocket fallback](/quest/m2/ffi-websocket-fallback.md) - moq-ffi and its wrappers gain the disable and delay setters the CLI and libmoq already have
61 changes: 0 additions & 61 deletions quest/m0/3533-ts-export-restart-stall.md

This file was deleted.

70 changes: 0 additions & 70 deletions quest/m0/3534-ietf-publisher-priority.md

This file was deleted.

63 changes: 63 additions & 0 deletions quest/m0/3588-anonymous-handoff.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
# [S] moq-net: anonymous handoff is proven on the source model

## Goal

An anonymous publisher session that dies without unannouncing is replaced by
the next anonymous session announcing the same path, and a subscriber on a
third anonymous session gets the newcomer's media with no parking and no 404.
On main the relay lingered the dead front, advertised it to the newcomer
before it announced, registered an `ExclusionGuard` for the id it had just
minted, and then read the newcomer's own announce as a reflection: parked
until the linger expired, 404 `dropped` meanwhile, failing interop cells
nightly. dev removed that mechanism; the fix is the model. This quest is the
proof, so the regression cannot come back through a merge. Branch from dev.

## Plan

What the tree does today, all in `rs/moq-net/src/model/origin.rs`:

- `FrontState` (line 1914) holds `next_source`, `sources`, `track_info`,
`active`, `closed`. No `excluded`, no guard, no linger, no `taints_a_reader`.
- `attach_source` (2078) joins the live front under one lock and the newest
source becomes active; a front whose sources have all closed is replaced by
a fresh broadcast rather than spliced into.
- `detach_source` (1990) closes the broadcast synchronously with its last
source, however the source ended.
- Loop detection is hop-based route filtering: `Consumer::excluding` (3501)
hides every route whose hop chain contains the peer, enforced in
`best_route` (3033). The lite publisher applies it at
`rs/moq-net/src/lite/publisher.rs:119`; the server mints `Hop::random()`
per accepted session at `rs/moq-net/src/server.rs:217`.
- The relay's `cluster.linger` is a hidden deprecated no-op
(`rs/moq-relay/src/cluster.rs:485`).

Work: two regression tests in the `origin.rs` test module, beside
`exclude_hides_routes_through_the_peer` (4331) and
`anonymous_routes_never_resume` (4991), using the same rig style.

- Handoff: session A (anonymous hop) attaches a source at a path; a consumer
from a third anonymous session resolves it. A's source is dropped without
an unannounce. Session B attaches a source at the same path. The consumer
resolves again and reads B's media; assert the front closed with A's last
source and B's front is served immediately, with no stale front at the leaf.
- Reflection, in the lite session harness rather than the origin rig: the
origin asserts a looping chain never reaches it (`origin.rs:1506`), and the
drop happens one layer up, where `rs/moq-net/src/lite/subscriber.rs`
(lines 267 to 305) discards an announce whose chain already names this
session or its origin. Beside the `SinkSession` tests at `subscriber.rs:1333`,
a peer that was advertised the path announces it back with the relay's own
hop in the chain; assert the announce is dropped, the local front keeps
serving, and the peer's own subscription is still served from it.

Then `just test smoke-full`: the nightly matrix
(`.github/workflows/smoke.yml:11`, `test/smoke/README.md:71`) runs
wire-anonymous clients that hit this path; confirm every cell passes on the
branch. Note the run in the PR.

## Closes

- [#3588](https://github.com/moq-dev/moq/issues/3588) - close this issue when the quest finishes

## Related

- [Anonymous rank](/quest/m1/anonymous-route-rank.md) - anonymous routes rank below identified ones
Loading
Loading