Skip to content

fix(nix): give the moq-cli check phase a trust store - #3734

Merged
kixelated merged 1 commit into
devfrom
fix/nix-cli-cacert
Sep 17, 2026
Merged

kixelated merged 1 commit into
devfrom
fix/nix-cli-cacert

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

nix build .#moq-cli fails its check phase on dev:

test tests::cluster_connect_api_http_attaches_client_tls ... FAILED
client: unexpected error: No CA certificates were loaded from the system

The test builds the connect TLS config, which loads native roots and (since the rustls-native-certs bump) errors when none are found. The nix sandbox has no system trust store. moqRelayArgs already carries the fix; moqCliArgs never got it.

Approach

Add the same two lines to moqCliArgs: cacert as a native build input and SSL_CERT_FILE pointing at its bundle. Verified with nix build .#moq-cli before (fails as above) and after (passes) on top of #3733.

Impact

  • No public API or wire change. Nix packaging only.

Alternatives

  • Skip the test under nix (doCheck = false): the package would stop running the CLI's tests, which the existing comment above src deliberately keeps.

Follow-ups

🤖 Generated with Claude Code

https://claude.ai/code/session_01CpMVbmhAWE3JwrXF3Cto1o

(written by Claude Opus 5)

@kixelated
kixelated marked this pull request as ready for review September 17, 2026 12:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-17T23:07:24.084675Z 21a11a7 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

MERGE

Positive, focused, and the right root-cause fix. The sandbox has no system trust store; pointing SSL_CERT_FILE at cacert is exactly what moqRelayArgs already does, and skipping the check would paper over a real failure mode.

Complexity is near zero; value is unblocking nix build .#moq-cli. No alternate approach is better.

Land #3733 first (this is stacked on it), then retarget/rebase onto dev as the description says.

(Written by Grok)

@kixelated
kixelated force-pushed the fix/msf-release-build branch from c42601c to 86f7479 Compare September 17, 2026 22:40
Base automatically changed from fix/msf-release-build to dev September 17, 2026 23:03
`cluster_connect_api_http_attaches_client_tls` builds the connect TLS
config, which loads native roots and errors when none are found. The
build sandbox has no system trust store, so the moq-cli package failed
its check phase. Point rustls-native-certs at cacert's bundle, as the
moq-relay package already does.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CpMVbmhAWE3JwrXF3Cto1o
@kixelated
kixelated enabled auto-merge (squash) September 17, 2026 23:08

Copy link
Copy Markdown
Collaborator Author

Rebased onto origin/dev after #3733 merged (d6a28bfc). The stacked msf commit dropped as already upstream; this PR is now just the two-line moqCliArgs trust-store fix (cacert + SSL_CERT_FILE), matching moqRelayArgs. Codex has no findings on 21a11a7. Squash auto-merge is enabled.

(written by grok-4.6)

@kixelated
kixelated merged commit d434cb3 into dev Sep 17, 2026
4 of 6 checks passed
@kixelated
kixelated deleted the fix/nix-cli-cacert branch September 17, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant