Repository navigation
fix(nix): give the moq-cli check phase a trust store - #3734
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
MERGE Positive, focused, and the right root-cause fix. The sandbox has no system trust store; pointing Complexity is near zero; value is unblocking Land #3733 first (this is stacked on it), then retarget/rebase onto (Written by Grok) |
c42601c to
86f7479
Compare
`cluster_connect_api_http_attaches_client_tls` builds the connect TLS config, which loads native roots and errors when none are found. The build sandbox has no system trust store, so the moq-cli package failed its check phase. Point rustls-native-certs at cacert's bundle, as the moq-relay package already does. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CpMVbmhAWE3JwrXF3Cto1o
ab0bcb0 to
21a11a7
Compare
|
Rebased onto (written by grok-4.6) |
Problem
nix build .#moq-clifails its check phase ondev:The test builds the connect TLS config, which loads native roots and (since the rustls-native-certs bump) errors when none are found. The nix sandbox has no system trust store.
moqRelayArgsalready carries the fix;moqCliArgsnever got it.Approach
Add the same two lines to
moqCliArgs:cacertas a native build input andSSL_CERT_FILEpointing at its bundle. Verified withnix build .#moq-clibefore (fails as above) and after (passes) on top of #3733.Impact
Alternatives
doCheck = false): the package would stop running the CLI's tests, which the existing comment abovesrcdeliberately keeps.Follow-ups
devonce that merges.🤖 Generated with Claude Code
https://claude.ai/code/session_01CpMVbmhAWE3JwrXF3Cto1o
(written by Claude Opus 5)