Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,10 @@ For each finding:
If you encounter issues, or findings that are out of scope, create follow-up quests.
Focus on the core problem, offering a potential solution only if its obvious.
For non-trivial tasks, file an issue or offer to run `/plan-quests`.

# Forks

[moq-dev/noq](https://github.com/moq-dev/noq) publishes `moq-noq*`, the QUIC stack every published MoQ crate builds on; iroh keeps upstream noq.
Its `moq-sync` workflow merges n0-computer/noq weekly as a PR; review it like any other, and `PARENT` names the upstream commit each release includes.
A carried change lists its upstream PR, or the reason it has none, in the fork PR.
For an advisory against noq or Quinn, compare the pinned release's `PARENT` with the fixing upstream commit, then sync, release the fork, and bump the pin here.
86 changes: 74 additions & 12 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@ moq-loc = { version = "0.2.8", path = "rs/moq-loc" }
moq-msf = { version = "0.4.2", path = "rs/moq-msf" }
moq-mux = { version = "0.9.16", path = "rs/moq-mux" }
moq-net = { version = "0.2.22", path = "rs/moq-net" }
# The MoQ fork of noq (moq-dev/noq). iroh keeps upstream noq, so a build with the
# iroh feature carries both stacks.
moq-noq-proto = { version = "1.3", default-features = false }
moq-noq-udp = "1.3"
# NVENC bindings, forked from ViliamVadocz/nvidia-video-codec-sdk to dlopen the
# driver at runtime. Compiles on any platform (macOS included) but only actually
# used by moq-video on Linux.
Expand Down Expand Up @@ -171,8 +175,8 @@ moq-vaapi = "0.0.4"
# that argument, so moq-ffi and libmoq opt NVIDIA, OpenH264, and VAAPI back in.
moq-video = { version = "0.0.25", path = "rs/moq-video", default-features = false }
nix = { version = "0.31.3", features = ["net", "socket", "uio"] }
# Upstream noq-proto, only for iroh's controller factory types.
noq-proto = { version = "1.2", default-features = false }
noq-udp = "1.1.1"
num_enum = "0.7"
objc2 = "0.6.4"
objc2-av-foundation = "0.3.2"
Expand Down Expand Up @@ -215,8 +219,8 @@ web-async = { version = "0.1.5", features = ["tracing"] }
web-transport-iroh = "0.7"
# default-features off so the QUIC crypto provider is chosen by moq-tokio's
# aws-lc-rs / ring features.
# 0.3 for the `qlog` passthrough feature moq-tokio's `qlog` forwards to.
web-transport-noq = { version = "0.3", default-features = false }
# The WebTransport adapter released with moq-noq, from the same repository.
web-transport-moq = { version = "1.3", default-features = false }
web-transport-proto = "0.6"
web-transport-trait = "0.4"
web-transport-wasm = "0.6"
Expand Down
7 changes: 1 addition & 6 deletions quest/future/multipath-spike.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ negotiated on any MoQ connection.
The spike is small: call that setter, add a max-paths knob beside the other
transport settings, and open a second path from the connect side. It rides
entirely below the `web_transport_trait` line, because
`web_transport_noq::Session` derefs to `noq::Connection` and the trait requires
`web_transport_moq::Session` derefs to `noq::Connection` and the trait requires
`Clone`, so the backend can hand one clone to moq-net and keep another to
drive paths on. No trait change, no moq-net change, and none belongs there: a
browser WebTransport backend could never implement it.
Expand Down Expand Up @@ -59,8 +59,3 @@ different name.

Target `dev`, where the crate is `moq-tokio`; the rename has not reached
`main`.

## Related

- [Fork noq](/quest/next/quic/fork.md) - noq's multipath support is one
reason it is the parent
4 changes: 0 additions & 4 deletions quest/future/quic-buffer-pool.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ noise and the idea is closed.
- `just bench BASE` on Linux: CPU per Gbps, RSS, and p99 latency. Ship only a
measured win.

## Required

- [Fork noq](/quest/next/quic/fork.md) - the seam lives there

## Related

- [#3204](/quest/next/perf/3204-moq-uring-register-tx-pool-buffers-for-zero-copy-sends.md) -
Expand Down
4 changes: 0 additions & 4 deletions quest/future/quic-careful-resume.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ Measure time to the encoder's target rate after a reconnect on the impaired
path profile, plus loss and latency during the jump. Ship it on by default
only when the jump never makes the first second worse than slow start.

## Required

- [Fork noq](/quest/next/quic/fork.md) - the controller wrapper lives there

## Related

- [Transport upgrade](/quest/next/transport-upgrade/README.md) - one of the
Expand Down
2 changes: 0 additions & 2 deletions quest/future/quic-ecn.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,5 @@ per path and only an ACK without counts turns it off, so both `off` and

## Required

- [Fork noq](/quest/next/quic/fork.md) - the `Ect1` option and the `off` knob
live there
- [Measure ECN on the backbone](/quest/next/quic/ecn-measure.md) - the
provider verdict this quest acts on
4 changes: 0 additions & 4 deletions quest/future/quic-keep-alive.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,3 @@ vars; NAT-sensitive deployments keep it as the new maximum, documented in
Tests: an idle connection survives an idle timeout with exactly one PING per
period; a busy connection sends none; a lost PING is probed before the
deadline; the maximum knob shortens the period.

## Required

- [Fork noq](/quest/next/quic/fork.md) - the timer change lives there
4 changes: 0 additions & 4 deletions quest/future/quic-receive-ts.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ written reason it does not pay.
The GCC experiment requires this; a delay-based controller without per-packet
arrival times is a different, weaker experiment.

## Required

- [Fork noq](/quest/next/quic/fork.md) - the extension lives there

## Related

- [QUIC GCC](/quest/future/quic-gcc.md) - the controller that consumes it
Expand Down
4 changes: 0 additions & 4 deletions quest/future/quic-send-batching.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ together, so the question there is whether it already gets the benefit.
A measured no-win abandons the tokio change; the io_uring result is recorded
either way.

## Required

- [Fork noq](/quest/next/quic/fork.md) - `moq-noq-udp` is the fork's

## Related

- [Kernel pacing](/quest/future/quic-kernel-pacing.md) - pacing per train
Expand Down
9 changes: 4 additions & 5 deletions quest/next/quic/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@ in [future](/quest/future/README.md).

## Plan

Everything here assumes the single noq stack. The [fork](/quest/next/quic/fork.md)
is the first quest in the line and most others require it.
Everything here ships from moq-dev/noq, the fork MoQ publishes as `moq-noq*`.
One stack carries every change on MoQ's own QUIC paths; a build with the `iroh`
feature also compiles upstream noq, and iroh connections are outside what these
quests reach.

The seven BBR correctness fixes follow the fork bootstrap. They are separate
PRs, but one owner should work in the shared controller code at a time.
Expand Down Expand Up @@ -44,9 +46,6 @@ This is a transport API change, not a MoQ wire change.

## Quests

- [Fork noq](/quest/next/quic/fork.md) - moq-dev/noq publishes `moq-noq-proto`,
`moq-noq`, and `moq-noq-udp`, tracks its parent, and the sync procedure is
written down
- [Preserve QUIC packet identity in BBR](/quest/next/quic/bbr-packet-identity.md) - ACKs and losses identify the right packet across QUIC spaces
- [Finish each BBR ACK sample before using it](/quest/next/quic/bbr-ack-sampling.md) - current delivery samples reach the model once with consistent metadata
- [Mark application starvation before the next BBR send](/quest/next/quic/bbr-app-limited.md) - resumed bursts retain correct sample labels
Expand Down
6 changes: 3 additions & 3 deletions quest/next/quic/ack-hook.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## Goal

A released `web-transport-trait` lets a sender await acknowledgment of a
named byte offset on a send stream, a released `web-transport-noq` implements
named byte offset on a send stream, a released `web-transport-moq` implements
it, and every other backend reports that it cannot rather than returning a
guess.

Expand All @@ -30,7 +30,7 @@ use. A default body cannot construct a backend's own `Self::Error`, so
unsupported has to live in the return type rather than the error, and a
consumer must treat `None` as unknown, never as delivered.

Implement it in `web-transport-noq` over the fork's accessor. Leave
Implement it in `web-transport-moq` over the fork's accessor. Leave
`web-transport-wasm` on the default; the browser's `WebTransportSendStream.getStats()` is
unimplemented in shipping Chrome and its `bytesAcknowledged` is at risk in the
W3C draft. qmux over a reliable transport may treat serialization as
Expand All @@ -42,7 +42,7 @@ the middle of an in-flight frame, several waiters on one stream in offset
order, a waiter whose offset lies beyond the final size, reset by sender,
STOP_SENDING by the receiver, and session close.

Cut releases of `web-transport-trait` and `web-transport-noq`. The quest
Cut releases of `web-transport-trait` and `web-transport-moq`. The quest
completes when both are on crates.io.

## Required
Expand Down
4 changes: 0 additions & 4 deletions quest/next/quic/ack-progress.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@ Land it in the fork and offer it upstream once it is stable. The quest
completes when a `moq-noq-proto` release carries the accessor and
`Cargo.lock` here can name it.

## Required

- [Fork noq](/quest/next/quic/fork.md) - the accessor lives there

## Related

- [poll_acked in web-transport](/quest/next/quic/ack-hook.md) - the first
Expand Down
4 changes: 0 additions & 4 deletions quest/next/quic/bbr-ack-sampling.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@ controller simulations and add regressions to the fork's CI. Coordinate
with packet identity work if the callback contract changes; settle the API
with the maintainer and update its consumers and docs in the same PR.

## Required

- [Fork noq](/quest/next/quic/fork.md) - fixes and CI regressions land in moq-dev/noq

## Related

- [Release BBR fixes](/quest/next/quic/bbr-release.md) - deliver the corrected controller to MoQ
Expand Down
4 changes: 0 additions & 4 deletions quest/next/quic/bbr-app-limited.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ any controller event changes with the packet identity and ACK sampling fixes.
Keep state private where possible; document any public Controller change and
its consumers. No wire change is intended. Wire regressions into fork CI.

## Required

- [Fork noq](/quest/next/quic/fork.md) - fixes and CI regressions land in moq-dev/noq

## Related

- [Finish each BBR ACK sample](/quest/next/quic/bbr-ack-sampling.md) - a separate ordering defect in the same callback lifecycle
Expand Down
4 changes: 0 additions & 4 deletions quest/next/quic/bbr-loss-undo.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ across ACK events. A new episode must get a new snapshot; real loss must
still constrain sending. Cover ProbeRTT interaction and add regressions to
the fork's CI. Keep the fix internal with no wire change.

## Required

- [Fork noq](/quest/next/quic/fork.md) - fixes and CI regressions land in moq-dev/noq

## Related

- [Release BBR fixes](/quest/next/quic/bbr-release.md) - deliver the corrected controller to MoQ
Expand Down
4 changes: 0 additions & 4 deletions quest/next/quic/bbr-packet-identity.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ other controllers and custom implementations. Settle any public API change
with the maintainer before implementation; document it inline. No QUIC wire
change is intended. Run the regressions in the fork's CI.

## Required

- [Fork noq](/quest/next/quic/fork.md) - fixes and CI regressions land in moq-dev/noq

## Related

- [Release BBR fixes](/quest/next/quic/bbr-release.md) - deliver the corrected controller to MoQ
Expand Down
4 changes: 0 additions & 4 deletions quest/next/quic/bbr-probe-feedback.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ short-term response applies. Include application-limited feedback and
ProbeRTT entry so neither leaves stale probe classification. Land these
regressions in the fork's CI without changing public APIs or the wire.

## Required

- [Fork noq](/quest/next/quic/fork.md) - fixes and CI regressions land in moq-dev/noq

## Related

- [Release BBR fixes](/quest/next/quic/bbr-release.md) - deliver the corrected controller to MoQ
Expand Down
4 changes: 0 additions & 4 deletions quest/next/quic/bbr-probe-rtt.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ Do not mark the connection application-limited forever or change the
ProbeRTT policy merely to mask a sampling bug. Add the regressions to the
fork's CI; keep the fix internal with no wire change.

## Required

- [Fork noq](/quest/next/quic/fork.md) - fixes and CI regressions land in moq-dev/noq

## Related

- [Release BBR fixes](/quest/next/quic/bbr-release.md) - deliver the corrected controller to MoQ
Expand Down
Loading
Loading