Repository navigation
quest: plan the origin failover state machine - #3891
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 9 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
MERGE Positive improvement? Yes. The root problem is concrete and historically grounded: wake predicates that disagree with the decision they guard (#3312 resume memo, Worth the complexity? Yes for an [L] planning quest. The simplifications pay for themselves: one source slot via existing Different approach? Not clearly better. Keeping the multi-source local table or a questline (design doc → implement) would either preserve the state sprawl this quest kills or split decisions that need to land together. Exhaustive model checking with an external crate would be heavier than the planned enumerator for a two-source/two-track bound. Ship the plan; watch these on the implementation PR:
This is an automated review, not the maintainer's decision |
|
No issues found. |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
No issues found. |
…ailover-machine # Conflicts: # quest/main/README.md
|
No issues found. |



Adds Origin failover machine at the top of main's list, planned in an interview after #3882 and #3884.
What it plans
One state machine per front, owning per-track state: events in, actions out, no locks or waiters inside, with the async task reduced to feeding events and executing actions. Every transition gets a runtime-free test and a bounded enumerator checks the invariants that wake predicates used to guard by hand. Subscribers keep today's guarantees.
Decisions settled in the interview:
resume::Producer's action surface may move. Per-track refusal skipping and the first-hop identity pin stay. Transparent failover stays a feature.Public API and wire impact
None; a planning document.
🤖 Generated with Claude Code
(written by Claude Fable 5.1)