Skip to content

fix(ci): repair nightly builds hidden behind the first failure - #3956

Merged
kixelated merged 2 commits into
mainfrom
claude/fix-nightly
Sep 23, 2026
Merged

kixelated merged 2 commits into
mainfrom
claude/fix-nightly

Conversation

@kixelated

@kixelated kixelated commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

The nightly just rs features recipe stops at its first broken configuration, so several later ones stayed hidden since the dev merge (#3793). Fixed each in turn until the recipe compiled end to end:

  • moq-relay tests/lan_mesh.rs: gated on cluster-lan (failed --no-default-features).

  • moq-uring tests/teardown.rs and benches/echo_noq.rs: gated on noq.

  • cargo hack --each-feature on moq-tokio now excludes the private _transport marker, which is documented as not enabled alone.

  • moq-video pipewire and renderer tests, and a moq-cli args test, updated to the current Frame and Duration types (only compiled under --all-features).

  • Windows job: moq-video Media Foundation capture logs Option<Rate> with ?.

  • moq-uring echo_noq test and bench: install the aws-lc-rs provider like tests/web.rs does. Under --all-features both ring and aws-lc-rs are on, so rustls has no implicit default; the client builder panicked on its thread and the server waited forever (a nextest TIMEOUT, not a failure).

Verified locally: just rs features passes end to end (5137 tests).

Drill mutation staleness is fixed separately in #3953.

No public API or wire impact.

(written by Opus 5.5)

🤖 Generated with Claude Code

The nightly features recipe stopped at the first broken configuration, so
several others stayed hidden:
- moq-relay lan_mesh test needs the cluster-lan feature.
- moq-uring teardown test and echo_noq bench need the noq feature.
- cargo-hack skips moq-tokio's private _transport marker, which is not
  meant to be enabled alone.
- moq-video and moq-cli tests updated to the current Frame and Duration types.
- moq-video Media Foundation capture logs the Option<Rate> with Debug.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ec4953d4-ccfb-4090-ba74-c83f70283c57

📥 Commits

Reviewing files that changed from the base of the PR and between 7ee2b02 and f5b2fc5.

📒 Files selected for processing (10)
  • rs/justfile
  • rs/moq-cli/src/args.rs
  • rs/moq-relay/tests/lan_mesh.rs
  • rs/moq-uring/Cargo.toml
  • rs/moq-uring/benches/echo_noq.rs
  • rs/moq-uring/tests/echo.rs
  • rs/moq-uring/tests/teardown.rs
  • rs/moq-video/src/capture/mediafoundation.rs
  • rs/moq-video/src/capture/pipewire.rs
  • rs/moq-video/src/render/renderer.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T17:18:26.462960Z b893979 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

MERGE (head b893979922bd8619922e6f00f4c0d7308ad4fdd8)

Positive improvement? Yes. Nightly just rs features was failing on the first broken matrix cell and masking several later ones. This unblocks the full feature-extreme compile path with small, targeted fixes.

Worth the complexity? Yes. The diff is tiny (+11/−9) and each change matches the failure mode:

  • Feature-gate lan_mesh and teardown / echo_noq so --no-default-features does not compile code that needs cluster-lan / noq.
  • Exclude private _transport from cargo hack --each-feature (it is not a standalone feature).
  • Update Frame / Duration / Option<Rate> call sites that only build under --all-features.

Different approach? Feature gating / required-features is the right fix; rewriting those tests to run without their features would add noise without value. One minor inconsistency: lan_mesh and teardown use #![cfg(feature = …)] while the echo_noq bench uses required-features in Cargo.toml. Both work; aligning on required-features later would be polish, not a blocker.

Good call leaving the separate echo_noq nextest timeout under full-workspace load for a follow-up instead of papering over it here. No public API or wire impact.

This is an automated review, not the maintainer's decision
(Written by Grok)

With --all-features, ring and aws-lc-rs are both enabled, so rustls has no
implicit default. The web-transport-moq client builder then panicked on its
thread while the server side waited forever, turning into a nextest timeout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated enabled auto-merge (squash) September 23, 2026 23:18
@kixelated
kixelated merged commit 6fad979 into main Sep 23, 2026
68 of 73 checks passed
@kixelated
kixelated deleted the claude/fix-nightly branch September 23, 2026 23:18
@kixelated

Copy link
Copy Markdown
Collaborator Author

Squash-merged.

Head had moved from b893979 (the MERGE comment) to f5b2fc5. The extra commit installs the aws-lc-rs provider in the echo_noq test and bench, same as tests/web.rs, so --all-features does not panic the client thread and hang the server. The rest is unchanged: feature-gate lan_mesh, teardown, and echo_noq; skip the private _transport marker in cargo hack; update Frame, Duration, and Option<Rate> call sites that only build at the feature extremes.

CI on f5b2fc5 was green (Check, Test, Android, OBS, Swift). No further code changes.

(written by Grok 4.7)

This was referenced Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant