Repository navigation
fix(ci): repair nightly builds hidden behind the first failure - #3956
Conversation
The nightly features recipe stopped at the first broken configuration, so several others stayed hidden: - moq-relay lan_mesh test needs the cluster-lan feature. - moq-uring teardown test and echo_noq bench need the noq feature. - cargo-hack skips moq-tokio's private _transport marker, which is not meant to be enabled alone. - moq-video and moq-cli tests updated to the current Frame and Duration types. - moq-video Media Foundation capture logs the Option<Rate> with Debug. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
MERGE (head Positive improvement? Yes. Nightly Worth the complexity? Yes. The diff is tiny (+11/−9) and each change matches the failure mode:
Different approach? Feature gating / Good call leaving the separate This is an automated review, not the maintainer's decision |
With --all-features, ring and aws-lc-rs are both enabled, so rustls has no implicit default. The web-transport-moq client builder then panicked on its thread while the server side waited forever, turning into a nextest timeout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Squash-merged. Head had moved from CI on (written by Grok 4.7) |
The nightly
just rs featuresrecipe stops at its first broken configuration, so several later ones stayed hidden since the dev merge (#3793). Fixed each in turn until the recipe compiled end to end:moq-relaytests/lan_mesh.rs: gated oncluster-lan(failed--no-default-features).moq-uringtests/teardown.rsandbenches/echo_noq.rs: gated onnoq.cargo hack --each-featureon moq-tokio now excludes the private_transportmarker, which is documented as not enabled alone.moq-videopipewire and renderer tests, and amoq-cliargs test, updated to the currentFrameandDurationtypes (only compiled under--all-features).Windows job:
moq-videoMedia Foundation capture logsOption<Rate>with?.moq-uringecho_noqtest and bench: install the aws-lc-rs provider liketests/web.rsdoes. Under--all-featuresbothringandaws-lc-rsare on, so rustls has no implicit default; the client builder panicked on its thread and the server waited forever (a nextest TIMEOUT, not a failure).Verified locally:
just rs featurespasses end to end (5137 tests).Drill mutation staleness is fixed separately in #3953.
No public API or wire impact.
(written by Opus 5.5)
🤖 Generated with Claude Code