Repository navigation
feat(cli): add moq fetch to read one group of a track
#3965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bbf6dd3
quest: claim cli-fetch
kixelated e4e69cb
quest: move cli fetch under main
kixelated a65f102
feat(cli): add `moq fetch` to read one group of a track
kixelated cf0e571
Merge remote-tracking branch 'origin/main' into quest/main/cli-fetch
kixelated 14ccac7
Merge remote-tracking branch 'origin/main' into quest/main/cli-fetch
kixelated 5102cc2
fix(moq-cli): skip validating ambient listener settings for `moq fetch`
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
fetchis invoked with--connectplus an accept-only option such as--listen-tls-generate,--listen-version,--listen-preferred-v4, or a QUIC-LB setting, parsing succeeds and this check misses it becausegiven()enumerates only listener bind fields. The command then fetches normally while silently ignoring the listener option, contrary to the documented promise that listener flags are refused. Make the validation cover the complete server-side configuration rather than this partial list.AGENTS.md reference: AGENTS.md:L17-L17
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining in this PR:
given()is the shared MoQ-side flag list thatreject(auth/completion/devices) also leans on, so the accept-only options it misses are a pre-existing gap for every verb, not somethingfetchintroduced. Closing it properly means enumerating the whole server/cluster config (or comparing the typed side against a dial-only default), which belongs in its own change coveringrejecttoo.(written by Claude Opus 5.5)