Repository navigation
chore(quest): drop Required bullets that have cleared #4109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -3,18 +3,13 @@ | |||||||||||||||||||||||||
| ## Goal | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| LOC video groups end with the empty frame that closes their last frame's | ||||||||||||||||||||||||||
| duration, the same contract the legacy container carries, once every released | ||||||||||||||||||||||||||
| LOC video consumer skips it. | ||||||||||||||||||||||||||
| duration, the same contract the legacy container carries. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| ## Plan | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| The consumer-side skip has landed in `rs/moq-mux/src/container/loc` and | ||||||||||||||||||||||||||
| `js/loc`; endpoint recognition is configured for media tracks so empty data | ||||||||||||||||||||||||||
| frames remain data. LOC producers are still silent, because a released LOC consumer | ||||||||||||||||||||||||||
| submits an empty payload to the decoder. When the bullet below clears, have | ||||||||||||||||||||||||||
| the LOC producers write the marker at `cut` and `finish` exactly as the | ||||||||||||||||||||||||||
| legacy producer does (`Container::finish_group` on `loc::Wire(Kind::Video)`), and extend the same tests. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| ## Required | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| - A release of `moq-mux` and `@moq/loc` whose video consumers skip an empty LOC payload has shipped | ||||||||||||||||||||||||||
| `js/loc`, and shipped in `moq-mux` 0.10.3 and `@moq/loc` 0.2.3. Endpoint | ||||||||||||||||||||||||||
| recognition is configured for media tracks, so empty data frames remain data. | ||||||||||||||||||||||||||
| Have the LOC producers write the marker at `cut` and `finish` exactly as the | ||||||||||||||||||||||||||
| legacy producer does (`Container::finish_group` on `loc::Wire(Kind::Video)`), | ||||||||||||||||||||||||||
| and extend the same tests. | ||||||||||||||||||||||||||
|
Comment on lines
+11
to
+15
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: set -eu
printf '%s\n' '--- changed plan ---'
git diff --no-ext-diff --unified=80 fd31194eeea45cc2a4ac096fc5bb04a19161dd6f 2a65fbc9bead04128b1ab1c4d7f97b41747059d2 -- quest/m1/loc-duration-marker.md
printf '%s\n' '--- candidate files ---'
git ls-files | rg '(^|/)(loc|mux|producer|container|wire|frame|duration|marker)' | head -200
printf '%s\n' '--- LOC and lifecycle references ---'
rg -n -S --glob '!node_modules' --glob '!target' '(loc::Wire|Wire<|finish_group|fn (cut|finish)|\\.cut\\(|\\.finish\\(|duration marker|duration_marker|Kind::Video|LOC)' . | head -400Repository: moq-dev/moq Length of output: 6851 🤖 get_repo_knowledge executed:
Length of output: 47655 🏁 Script executed: set -eu
printf '%s\n' '--- Rust LOC outline and source ---'
ast-grep outline rs/moq-mux/src/container/loc/mod.rs
cat -n rs/moq-mux/src/container/loc/mod.rs
printf '%s\n' '--- generic producer and group definitions ---'
ast-grep outline rs/moq-mux/src/container/producer.rs
ast-grep outline rs/moq-mux/src/container/group.rs
cat -n rs/moq-mux/src/container/producer.rs
cat -n rs/moq-mux/src/container/group.rs
printf '%s\n' '--- legacy finish-group references ---'
rg -n -C 8 -F 'finish_group' rs/moq-mux/src
printf '%s\n' '--- Rust LOC and lifecycle references ---'
rg -n -C 5 -F 'loc::Wire' rs js
rg -n -C 5 -E 'fn (cut|finish)|\.cut\(|\.finish\(' rs/moq-mux js/loc js/binary js/json
printf '%s\n' '--- JavaScript LOC implementation and tests ---'
ast-grep outline js/loc/src/index.ts
cat -n js/loc/src/index.ts
cat -n js/loc/src/index.test.tsRepository: moq-dev/moq Length of output: 43338 🏁 Script executed: set -eu
printf '%s\n' '--- Container trait ---'
cat -n rs/moq-mux/src/container/mod.rs | sed -n '1,215p'
printf '%s\n' '--- Legacy wire implementation ---'
cat -n rs/moq-mux/src/container/legacy/mod.rs
printf '%s\n' '--- LOC producer lifecycle and tests ---'
cat -n rs/moq-mux/src/container/producer.rs | sed -n '470,540p'
cat -n rs/moq-mux/src/container/producer.rs | sed -n '1080,1195p'
printf '%s\n' '--- LOC catalog dispatch ---'
cat -n rs/moq-mux/src/catalog/hang/container.rs | sed -n '1,125p'
printf '%s\n' '--- JavaScript LOC files ---'
cat -n js/loc/src/index.ts
cat -n js/loc/src/index.test.ts
rg -n -C 5 -F 'finish_group' js rs/moq-mux/src | head -200Repository: moq-dev/moq Length of output: 40763 Specify a LOC-specific
Suggested fix-Have the LOC producers write the marker at `cut` and `finish` exactly as the
-legacy producer does (`Container::finish_group` on `loc::Wire(Kind::Video)`),
-and extend the same tests.
+Implement a LOC-specific `Container::finish_group` on
+`loc::Wire(Kind::Video)`. The hook is called by `cut` and `finish` before the
+group closes, and must append a LOC-encoded frame with the endpoint timestamp
+and an empty codec payload. Do not copy Legacy's raw frame writer. Preserve
+empty `Kind::Data` payloads as media, and extend the same tests.📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Keep the JavaScript consumer prerequisite blocked.
@moq/loc0.2.3 does not recognize media-track end markers. Its decoder returns an empty payload as an ordinary frame. Therefore, the plan cannot state that the consumer prerequisite shipped in both releases. Keep the prerequisite blocked until the JavaScript consumer recognizes media-track end markers and preserves emptyKind::Dataframes.🤖 Prompt for AI Agents