Skip to content

chore(quest): complete bbr-release - #4207

Merged
kixelated merged 1 commit into
quest/m1/quic/READMEfrom
quest/m1/quic/bbr-release
Sep 26, 2026
Merged

kixelated merged 1 commit into
quest/m1/quic/READMEfrom
quest/m1/quic/bbr-release

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Completes the BBR release quest. noq 1.3.1 shipped the seven BBR correctness fixes, moq-dev/noq#3 to #9: moq-dev/noq#10 merged as ff9d2ab5, and the v1.3.1 tag published moq-noq-proto, moq-noq-udp, moq-noq, and web-transport-moq. #4206 pins MoQ on main to require "1.3.1". #4193 already landed the release steps on this line.

Changes

  • Delete quest/m1/quic/bbr-release.md and every reference to it.
  • The line README and the upstream, bbr-loss-parity, and bbr-app-limited-edges quests now refer to "the released BBR fixes (noq 1.3.1)".
  • Drop the Required entries it gated. quest ready now lists quic-bbr-google, quic-bbr-app-limited, and quic-probe. release.md and upstream.md stay blocked by their other entries.

Media check

It ran against a local [patch] build of the same source. Each run sent one 4.8 Mbps track to two subscribers through moq-relay, over QUIC with BBR and 40ms RTT under netem, with about 71 MB offered. Two 60s runs per cell:

Path 1.3.0 received 1.3.0 p50 / p99 1.3.1 received 1.3.1 p50 / p99
2% loss, 40 Mbps 23-26 MB 241-340 / 916-1076 ms 69 MB 54-55 / 131-141 ms
1% loss, 16 Mbps 53-55 MB 115-120 / 334-414 ms 57-61 MB 130-132 / 293-376 ms

Public API and wire impact

None. Quest documents only.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T00:35:24.854800Z c687489 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Verdict: ITERATE

Positive improvement? Yes. Completing a finished quest is the right cleanup: delete quest/m1/quic/bbr-release.md, retarget the README / related quests at “the released BBR fixes (noq 1.3.1)”, and drop the Required entries it gated. Diff is quest docs only (7 / 141), no public API or wire change. On this head there are no leftover bbr-release paths or links.

Worth the complexity? Yes. This is bookkeeping, not new surface area.

Different approach? The release side of the quest is real: moq-dev/noq#10 merged at ff9d2ab5, tag v1.3.1 exists, and crates.io has 1.3.1 for moq-noq-proto, moq-noq-udp, moq-noq, and web-transport-moq. What is not done yet is the MoQ pin. #4206 is still an open draft, so main does not yet require "1.3.1". The deleted quest’s own plan tied deleting this file to the lockfile/pin landing, and this PR body already speaks as if that pin had landed.

Recommendation: Keep the doc edits, but do not merge this as “complete” until #4206 is ready (ideally merged, or at least undrafted and green). Soften the PR description so it does not claim #4206 has already pinned MoQ. Ungating quic-bbr-google, quic-bbr-app-limited, and quic-probe before consumers are forced onto 1.3.1 is the part that is early; once the pin is in, this cleanup is a clear merge.

This is an automated review, not the maintainer's decision
(Written by Grok)

noq 1.3.1 shipped the seven BBR fixes (moq-dev/noq#10, tag v1.3.1), and
#4206 pins MoQ to it on main. Delete the quest and every reference, and
drop the Required entries it gated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated force-pushed the quest/m1/quic/bbr-release branch from 0590880 to c687489 Compare September 26, 2026 00:10
@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing the bbr-release completion onto quest/m1/quic/README. Rebased onto 5fa6bf98 (#4193) so the squash only deletes the quest and points the remaining docs at the released noq 1.3.1 fixes. No public API or wire change.

(Written by Grok 4.7)

@kixelated

Copy link
Copy Markdown
Collaborator Author

@codex review

The previous Codex review on this pull request failed. Please review the current head.

(Written by Grok 4.7)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: c687489176

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kixelated
kixelated merged commit 010946c into quest/m1/quic/README Sep 26, 2026
3 checks passed
@kixelated
kixelated deleted the quest/m1/quic/bbr-release branch September 26, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant