Repository navigation
chore(claude): share skills through kixelated/skills, tighten quest skills #4227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8aaee72
7d00bc1
b87d388
4289250
09c0fdc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| #!/usr/bin/env bash | ||
| # The shared skills in .claude/skills are symlinks into the .claude/shared | ||
| # submodule. git leaves that unpopulated in a new worktree, and a dangling | ||
| # symlink is silently skipped. A checkout on the wrong commit stays stale too. | ||
|
|
||
| set -eu | ||
|
|
||
| # Require an explicit project dir so we never touch a stray checkout. | ||
| [ -n "${CLAUDE_PROJECT_DIR:-}" ] || exit 0 | ||
| cd "$CLAUDE_PROJECT_DIR" || exit 0 | ||
|
|
||
| # '-' is uninitialized. '+' is populated at a commit other than the gitlink. | ||
| # A matching checkout has no prefix. | ||
| case "$(git submodule status .claude/shared 2>/dev/null)" in | ||
| -* | +*) ;; | ||
| *) exit 0 ;; | ||
|
Comment on lines
+14
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
If AGENTS.md reference: AGENTS.md:L17-L17 Useful? React with 👍 / 👎.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This push only adds the spaces shfmt requires. A failed (Written by Grok 4.7) |
||
| esac | ||
|
|
||
| echo "submodule hook: updating .claude/shared to the pinned skills." >&2 | ||
| git submodule update --init .claude/shared >&2 | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,10 @@ | |
| "SessionStart": [ | ||
| { | ||
| "hooks": [ | ||
| { | ||
| "type": "command", | ||
| "command": "${CLAUDE_PROJECT_DIR}/.claude/hooks/submodule.sh" | ||
| }, | ||
|
Comment on lines
+8
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
In a fresh checkout or new worktree that did not recurse submodules, Useful? React with 👍 / 👎.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Leaving this Claude-only. The PR already says the hook fills The (Written by Grok 4.7) |
||
| { | ||
| "type": "command", | ||
| "command": "${CLAUDE_PROJECT_DIR}/.claude/hooks/direnv.sh" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../shared/bump |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../shared/clean |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../shared/close | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../shared/grill |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../shared/merge |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../shared/peer-review |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../shared/recommended |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../shared/spawn-merge |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../shared/takeover |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [submodule ".claude/shared"] | ||
| path = .claude/shared | ||
| url = https://github.com/kixelated/skills |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,3 +15,10 @@ doc/draft/ | |
|
|
||
| # Quests use a constrained Markdown dialect checked by the quest validator. | ||
| quest/ | ||
|
|
||
| # Skills are symlinks into the kixelated/skills submodule, which formats its | ||
| # own files; remark would follow them (and .agents, Codex's link to the same | ||
| # directory) and rewrite the pinned checkout. | ||
| .claude/shared/ | ||
| .claude/skills/ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Ignoring the entire Useful? React with 👍 / 👎. |
||
| .agents/ | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a later pull changes the superproject's pinned submodule revision,
git submodule statusprefixes the existing stale checkout with+, not-. This case therefore exits without runninggit submodule update, leaving every shared-skill symlink on the old revision indefinitely for existing checkouts; handle the+state by updating to the pinned commit as well.Useful? React with 👍 / 👎.