Repository navigation
chore: pin shared skills; document package versions in CONTRIBUTING #4272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
77a918a
bc6db0d
a9e3cc7
a8dcac8
9a13349
fd5b4ae
1e5f778
cc15c1b
0ba6265
f138ff1
9fbbf38
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,3 +57,14 @@ For non-trivial tasks, file an issue or offer to run `/plan-quests`. | |
| Its `moq-sync` workflow merges n0-computer/noq weekly as a PR; review it like any other, and `PARENT` names the upstream commit each release includes. | ||
| A carried change lists its upstream PR, or the reason it has none, in the fork PR. | ||
| For an advisory against noq or Quinn, compare the pinned release's `PARENT` with the fixing upstream commit, then sync, release the fork, and bump the pin here. | ||
|
|
||
| # Versions | ||
|
|
||
| Releases are cut separately; bump only when asked. Each package's version lives in one place: | ||
|
|
||
| - **Rust**: release-plz owns crate versions and Rust dependency requirements. | ||
| - **JavaScript**: `js/*/package.json` packages with a `scripts.release` entry (skip private ones like `@moq/clock`, `@moq/wasm`), plus the matching workspace version in `bun.lock`. | ||
| - **Python**: `py/moq-rs/pyproject.toml` only; `py/moq-ffi` follows the `moq-ffi-v*` tag and Rust crate. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When AGENTS.md reference: AGENTS.md:L28-L28 Useful? React with 👍 / 👎. |
||
| - **Swift**: `swift/VERSION`. **Kotlin**: `moq.version` in `kt/gradle.properties`. **Dart**: `version` in `dart/moq/pubspec.yaml`. Their FFI counterparts track the Rust crate. | ||
| - **Go**: `go/wrapper/VERSION` holds a human-owned `MAJOR.MINOR` line; CI derives the patch, so only edit it for a breaking API. Leave the placeholder FFI version in `go.mod` alone. | ||
| - **OBS**: the plugin takes the `libmoq` crate's version (`cpp/obs/CMakeLists.txt`), so release-plz owns it. | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
/bumpis used for the independently published Dart wrapper, this supposedly complete source-of-truth section provides no Dart entry. The Release Dart workflow reads the version fromdart/moq/pubspec.yaml, whiledart/moq_ffifollows the Rustmoq-ffi-v*tag, so omitting both can cause the generic skill to skip Dart or infer the wrong source; document them alongside the other language bindings. (Written by GPT-5.6 Sol)Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 9fbbf38: Dart now lists
dart/moq/pubspec.yaml, withmoq_fficovered by the FFI-counterparts note.(Written by Claude Opus 5.5)