Repository navigation
fix(gst): keep waiting for a keyframe after a header-only buffer - #4356
Conversation
After a video break, the sink cleared its keyframe-wait latch on any successful decode. A header-only buffer (SPS/PPS with no slice) decodes fine but publishes no frame, so no group opened and the next delta hit MissingKeyframe, invalidating the pad for good. The latch now stays set once armed. A delta only misses its keyframe while no group is open, which for video means after a break, so there is nothing to clear once a keyframe opens the group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
MERGE Positive improvement: after a video break, a header-only SPS/PPS buffer can decode successfully without opening a group. Clearing the keyframe latch on that success left the next delta to hit Worth the complexity: net simplification (one assignment removed) plus a focused regression test. No public API or wire change. Preferable to adding a "did publish a frame" signal from Different approach: none needed. The latch is already re-armed on discontinuity for video, and This is an automated review, not the maintainer's decision |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review. WalkthroughAfter a video discontinuity, successful decodes no longer clear the keyframe-wait flag. Deltas remain dropped until a keyframe opens a group. A new test checks this behavior with a header-only buffer, a delta, a keyframe, and a subsequent delta. The related quest entry and proposal were removed. Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The change preserves keyframe waiting after a break, with no actionable merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary
(Written by Opus 5.5) |
Follow-up to #4239 (Codex P1: #4239 (comment)).
Completes and deletes
quest/m1/moqsink-keyframe-latch.md.Bug
After a video break (pause, seek, flush),
moqsinkdrops deltas until a keyframe reopens the group. The latch was cleared after any successful decode, including one that published nothing: an SPS/PPS-only buffer decodes fine, but the H.264 split emits no frame without a slice, so no group opens. The next delta then hitMissingKeyframeand invalidated the pad permanently.Fix
Stop clearing the latch. A delta only misses its keyframe while no group is open, which for a video pad means after a break (which re-arms the latch anyway), so there is nothing to clear once a keyframe opens the group. This avoids needing a "did decode publish a frame" signal from
moq_mux::import::Track, which would be a public API change.Regression test
video_header_only_buffer_keeps_waiting_for_the_keyframefails onmainwithFailed("missing keyframe ...")and passes here.Maintainer decisions
Impact
(Written by Opus 5.5)
🤖 Generated with Claude Code