Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ For each finding:

Wait for Codex to review the final head before merging.
Merge only on its thumbs up, or once every Codex finding on the PR is fixed or replied to.
Codex skips fork PRs; ask the maintainer to request one.

# Follow-ups

Expand Down
1 change: 1 addition & 0 deletions quest/m1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ transport, benchmark tooling); worktrees isolate commits, not semantics.
- [TS import shared shift](/quest/m1/ts-import-shared-shift.md) - unflagged loop wraps move audio and video by one shift, so A/V sync holds across wraps
- [PipeWire duplicate cameras](/quest/m1/pipewire-dup-cameras.md) - a webcam lists once with PipeWire enabled
- [Catalog wall clock](/quest/m1/catalog-wall-clock.md) - `Clock::wall_clock` keeps the catalog's full precision instead of truncating to milliseconds
- [IPv6 TLS names](/quest/m1/ipv6-tls-name.md) - dialing an IPv6 literal completes TLS on WebSocket as on noq, including a bare `::1` host override
- [Capture control](/quest/m1/capture-control.md) - on dev, `encode::Capture` replaces `CaptureOptions`, an unsupported `cut()` errors, and dropping the last `Control` cancels in-flight opens
- [Video surface](/quest/m1/video-surface.md) - on dev, moq-ffi's `native` becomes `surface`, refused on platforms with no surface
- [HLS discontinuity sequence](/quest/m1/hls-discontinuity-sequence.md) - on dev, `Segment::discontinuity` is the absolute sequence, so every cursor agrees
Expand Down
28 changes: 28 additions & 0 deletions quest/m1/ipv6-tls-name.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# [XS] IPv6 literal TLS names on every TLS dialer

## Goal

Dialing an IPv6 literal (`wss://[::1]:4443`, `moqt://[::1]`) completes the TLS
handshake on both moq-tokio TLS dialers, noq and WebSocket, with or without a
pinned `Addr` and with or without a `tls_host_name` override.
[#4322](https://github.com/moq-dev/moq/pull/4322) fixes noq, where
`url::Host::to_string()` kept the URL brackets and rustls refused `[::1]` as a
server name.

WebSocket likely already works without an override: every path, including the
pinned `connect_tls_override` one, hands tokio-tungstenite a bracketed URL, and
it strips the brackets before building the rustls name. The known gap is a bare
IPv6 override (`tls_host_name = "::1"`): `connect_tls_override` passes it to
`Url::set_host`, which rejects it, while noq accepts it.

## Plan

- Pin WebSocket with loopback `[::1]` tests like #4322's: unpinned and pinned
`Addr` with no override, and a bare `::1` override. Fix only what fails.
- Derive the TLS server name the same way on both dialers. A shared helper is
reasonable if both need it.
- Keep the bracketed form wherever it is correct: the HTTP `Host` header and
URL rebuilding.
- TCP is plaintext and iroh dials by endpoint id, so neither is in scope.

Public API and wire: none.
Loading