Repository navigation
chore(quest): settle the PR-merge session's follow-ups #4468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # [XS] The alias check runs on macOS | ||
|
|
||
| ## Goal | ||
|
|
||
| `just cpp check` passes its "every generated `moq::MoqFoo` has a `moq::Foo` | ||
| alias" step on macOS outside the dev shell, so the C++23 probe after it runs. | ||
| Today the second `sed -nE` in `cpp/justfile` matches with a backreference | ||
| (`= Moq\1;`), which BSD `sed` ignores, so the alias list comes back empty and | ||
| every type reports missing. CI runs Ubuntu with GNU `sed` and never sees it. | ||
|
|
||
| ## Plan | ||
|
|
||
| Extract both names from each `using` line and compare them in `awk` (or | ||
| another portable tool) instead of a backreference in the pattern. Check it | ||
| with `/usr/bin/sed` first on PATH. | ||
|
|
||
| Public API: none. Wire: none. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # [S] JS LOC producer writes the duration marker | ||
|
|
||
| ## Goal | ||
|
|
||
| `@moq/loc`'s `Producer` ends each video group with the empty frame that closes | ||
| its last frame's duration, as `moq-mux`'s LOC producer does after | ||
| [#4450](https://github.com/moq-dev/moq/pull/4450). Readers skip it from | ||
| `@moq/loc` 0.2.3 and `moq-mux` 0.10.0 onward (the Rust skip landed in | ||
| [#3575](https://github.com/moq-dev/moq/pull/3575)). | ||
|
|
||
| ## Plan | ||
|
|
||
| The JS producer (`js/loc/src/index.ts`) has no frame kind, cut, or finish: it | ||
| closes a group on the next keyframe and on `close()`. Write the marker at both | ||
| points, and extend the producer tests to assert it and that the JS consumer | ||
|
Comment on lines
+13
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When implemented as written, AGENTS.md reference: AGENTS.md:L59-L62 Useful? React with 👍 / 👎. |
||
| skips it. Low urgency: only a test and a `js/hang` re-export use the producer | ||
| today; `js/publish` does not. | ||
|
|
||
| Public API: none. Wire: the same marker Rust writes. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # [XS] moq play plays a finished track's last samples | ||
| # [S] moq play plays a finished track's last samples | ||
|
|
||
| ## Goal | ||
|
|
||
|
|
@@ -13,11 +13,13 @@ tolerates the gap. | |
| ## Plan | ||
|
|
||
| The 10 ms stop exists because polling the last partial period costs a wakeup | ||
| per iteration and never settles. Fix it at the sink instead of the poll: let | ||
| a dropped or finished `moq_audio::playback::Sink` play out what it holds | ||
| before leaving the mix, or give it an end-of-stream that the mixer honors, so | ||
| `drain` no longer needs a threshold. If that belongs in moq-audio's playback | ||
| API, keep the change additive. | ||
| per iteration and never settles. Fix it at the sink instead of the poll | ||
| (maintainer decision, 2026-09-28): `Sink::finish` consumes the sink and | ||
| returns a `Drain` that resolves once the mixer has played everything the sink | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Limit the completion guarantee to accepted samples.
🤖 Prompt for AI Agents |
||
| held, then leaves the mix. `drain` awaits it and loses its threshold. Lowering | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win Include the CLI sink abstraction in the plan.
🤖 Prompt for AI Agents |
||
| the threshold to zero is rejected: it is the wakeup spin above. The change to | ||
| moq-audio's playback API is additive; dropping a sink still leaves the mix | ||
| immediately. | ||
|
|
||
| Tighten `an_audio_rendition_switch_leaves_no_gap` (the `play::fake::Recorder` | ||
| already models the cut on drop) so the lost tail fails it, and add a finite | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Describe the loss length as a packet duration, not a frame.
PR
#4442uses the last decoded packet’s sample count for concealment. An Opus packet can contain multiple frames, so “one Opus frame” describes the wrong unit and could misdirect the port. Change this to “one lost packet’s duration” or equivalent. (github.com)🤖 Prompt for AI Agents