Repository navigation
fix(net): track tail hardening #4533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2816898
quest: claim track-tail-hardening
kixelated d498efb
fix(net): harden the Rust track tail
kixelated 75df2bf
fix(net): harden the JS track tail to match Rust
kixelated eba9e2b
fix(net): abort on a contradicted lite end from lite-06
kixelated 17df808
quest(m1): plan reader end parity and visible dropped groups
kixelated 03bd421
fix(net): restart a gap's age when a lowered floor asks for it
kixelated 9c0fbc8
Merge remote-tracking branch 'origin/main' into quest/m1/track-tail-h…
kixelated 3c144e6
fix(net): hold an IETF subscription's end open across the fill handoff
kixelated 9d2f0a7
docs(net): note that a folded tail gap stays folded
kixelated 3ec3169
Merge remote-tracking branch 'origin/main' into quest/m1/track-tail-h…
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This 50 ms sleep is the synchronization that determines whether the regression catches the old early-close behavior. On a loaded CI runner, a broken subscription may not finish teardown before the sleep returns, allowing groups 1 and 2 to arrive first and making the test pass spuriously. Advance mocked time and drain the relevant tasks deterministically instead of depending on scheduler timing.
AGENTS.md reference: AGENTS.md:L19-L19
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining. The mock transport is in-process with no timers, so the broken teardown is a microtask chain: every queued microtask drains before any timer fires, and a loaded runner only delays the timer, never the chain. The 50 ms is an event-loop drain, not a race. The age logic itself is now covered with an injected clock in
tail.test.ts.(Written by Claude Opus 5.5)