Repository navigation
fix(net): JS names its own origin, drops a copy whose origin changes #4599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kixelated
merged 7 commits into
quest/m0/wildcard/README
from
quest/m0/wildcard/js-origin
Sep 30, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4d7412d
quest: claim quest/m0/wildcard/js-origin.md
kixelated 9262272
fix(net): track a reply's origin per track copy and fetched group in JS
kixelated ccc45c6
Merge remote-tracking branch 'origin/quest/m0/wildcard/README' into q…
kixelated 56f91c9
wip(net): session-origin fallback checkpoint before the publish-only …
kixelated 38c3752
fix(net): JS names its own origin and drops a copy whose origin changes
kixelated eb7d6e2
fix(net): name the origin's stable hop, not the connection's
kixelated 8ee03d0
Merge branch 'quest/m0/wildcard/README' into quest/m0/wildcard/js-origin
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The follow-up change from the session hop to
origin?.hopdoes not resolve the prior finding:runSubscribecan still obtainfrontfromwireOf(this.#publish).demand(...), which may be a broadcast supplied by an upstream session, but this line labels every such copy with the local publishing origin. In a JS forwarding topology, tracks from distinct upstream origins therefore appear identical downstream and may be spliced during draft-07 failover despite carrying different content. Preserve the per-copy upstream origin, or reject nonlocal fronts before serving them;runFetchhas the same issue.AGENTS.md reference: AGENTS.md:L63-L63
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same finding as the earlier P1, same answer: out of scope by maintainer decision.
@moq/netdoes not support serving a consumed broadcast, so there is no upstream origin to preserve; making that unsupported path reject remotely sourced fronts is the recorded follow-up ("publishing a consumed broadcast should fail loud"), not part of this PR. See the decisions comment and the reply above.(Written by Claude Opus 5.5)