Repository navigation
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
|
Upstream implementation is prepared in moq-dev/web-transport#412 and moq-dev/web-transport#413. Focused suites pass 189 tests on 0.6 and 181 on 0.5, including doctests. Both new end-to-end regressions fail against unmodified 0.5.2; focused Clippy passes for the backport. This quest remains blocked on upstream merge/release before the main/dev pins can consume fixed versions. Broad upstream checks and CI remain pending; all three PRs stay drafts. Public API and wire format are unchanged. No packages were published and no PRs were merged. Recommendation: complete upstream CI/review, merge and publish both patch lines, then resume the MoQ pin updates and fallback validation. (written by GPT-6) |
Co-Authored-By: GPT-6 <noreply@openai.com>
|
Final sources are pushed: #412 at 82527d2 and #413 at 1adcb9c. Complete qmux tests and focused Clippy pass on these sources: 189 tests on 0.6 and 181 on 0.5, including doctests. The last guard preserves the legacy binding's lack of flow control. Both end-to-end regressions fail against unmodified qmux 0.5.2. The newly published qmux 0.6.2 contains the earlier receive-map lookup fix, not these credit/close fixes. MoQ must consume releases containing #412/#413 after review and merge. Broad checks with web-transport's pinned Rust 1.94 toolchain and latest-head CI remain pending. All PRs remain drafts; no packages were published or PRs merged by this work. Recommendation: complete upstream checks/review, merge/release both lines, then resume MoQ main/dev pin updates tracked in #4705. No unresolved API or wire choices. (written by GPT-6) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 53 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as superseded: main's quest/m0/qmux-credit.md was already rewritten for the trunk flip (main on qmux 0.6.1, release on 0.5.2), so this rewrite is stale. The two upstream links (moq-dev/web-transport#412 for 0.6, #413 for 0.5) will be added to main's quest in a small follow-up. (Written by Claude Opus 5.5) |
Problem
The qmux credit/close quest needs fixes on both published lines before MoQ can consume patched releases. Source fixes are ready for upstream review, but the releases do not exist yet.
Approach
Record moq-dev/web-transport#412 (0.6) and moq-dev/web-transport#413 (0.5), their reproduced regressions and focused validation, and the remaining merge, release, and pin steps. Keep the quest open until both lines are released and MoQ's pins are validated.
Impact
Validation
quest checkandgit diff --checkpass. Upstream focused suites pass 189 tests on 0.6 and 181 tests on 0.5, including doctests. The two end-to-end regressions fail against unmodified 0.5.2. Broad upstream validation and CI remain pending.Alternatives
An unreleased or fabricated version pin would leave the quest unusable. The quest stays actionable while upstream review and publication proceed.
Follow-ups
Merge/release both upstream fixes, including the maintainer release process for the 0.5 branch, then update main/dev pins and validate the fallback. No PRs were merged or packages published.
(written by GPT-6)