Repository navigation
feat(cli)!: replace moq ls with follow-only moq announced - #4877
Conversation
`moq announced [prefix]` follows announcements until interrupted. On a
terminal it redraws the announced set in place; piped it prints the same
`+ path` / `- path` lines as `ls --follow`, and `--json` the same
`{"path", "active"}` objects. `moq ls`, its one-shot mode, and `--follow`
are gone.
Shell completion is local-only: the `--broadcast`, `--video-name`, and
`--audio-name` completers no longer dial a relay or read a catalog, and the
plumbing that existed only to let them dial goes with them. Nothing in
moq-cli reads the announce `Live` marker any more, which unblocks
quest/m1/announce-live-removal.md.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Outcome: the quest is implemented in full and Open decisions (recommendation first):
(Written by Claude Opus 5.5) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Cursor-up cannot reach a line that scrolled off the top, so a set taller than the terminal pushed stale copies into scrollback and showed only its tail. Draw what fits and end in a count of the rest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review of 5e5b0a6239e14317f4c0c3f317e9a1ebf8f6ea2e (Codex adversarial review plus a read-through)
Verdict: one real finding, fixed in cc4918da3. No design concerns.
- [medium] The live view overflowed the terminal (Codex).
Viewmoved up by the whole set's line count, but cursor-up stops at the top of the screen. Once the set was taller than the terminal, each redraw pushed stale copies into scrollback and only the tail stayed visible. Reproduced with avt100virtual terminal: 6 paths on a 4-row screen showedc d e. Fixed by drawing what fits (one row is kept for the cursor) and ending in(N more). The height is read per frame viaterminal_size, so a resize applies on the next change. The newthe_view_fits_the_terminaltest plays the frames onvt100, including a shrink.doc/bin/cli.mdmentions the count. - Read-through: the
lsand--followremovals are complete; nomoq lsinvocation remains in docs, recipes, or demos.Event::LiveandUpdatefall through_ => continue, soannounce-live-removalcan delete the variant without touching the CLI. The connection-closed branch is checked first, so a closing session's retractions are not printed as- pathlines. Completion no longer dials, andcompletion_never_dialsproves it against a live listener. - Not addressed, already a recorded follow-up: paths are printed raw, so control characters in a publisher-chosen path reach the terminal.
(Written by Claude Opus 5.5)
|
Grok review of
BlockingNone. Non-blocking
CIEvery job was still queued when I checked, so this assumes it goes green. Verdict: MERGE (once CI is green) This is an automated review, not the maintainer's decision |
# Conflicts: # quest/m1/README.md
Quest:
quest/m1/cli-announced.md(deleted here as complete).Problem
moq lsone-shot mode and network shell completion are the only readers of the announceLivemarker, which Delete the live marker removes because an origin fed by many sessions cannot honestly answer "caught up".Approach
moq lsbecomesmoq announced [prefix] [--json], follow-only, until interrupted. Exits non-zero when the session ends.--json: redraws the announced set in place (cursor-up and erase, autowrap off while drawing so long paths cannot break the line count). A set taller than the terminal shows what fits and ends in(N more), since cursor-up cannot reach lines that scrolled away; the height comes fromterminal_size, read per frame.+ path/- pathlines, byte-for-byte whatls --followprinted.--jsonprints the same{"path", "active"}objects.BROADCAST,VIDEO_NAME, andAUDIO_NAMEcompleters plus everything that only let them dial: the thread-local globals,MoqSide::from_argv,args::Environment, the partial-arg readers, and themoq-msfdev-dependency. Capture-device completers stay.rs/moq-clireadsAnnounceEvent::Liveany more.announce-live-removalloses itsRequiredentry and is now unblocked.doc/bin/cli.md,doc/bin/inspect.md,doc/bin/relay/http.md.doc/concept/moq-lite.mdonly mentions Unixls(dotfiles), so it is unchanged.Tests: the existing relay-backed tests now cover the event lines, JSON, and session loss. New tests cover the redraw frames, overflow and shrink on a
vt100virtual terminal,lsand--followbeing refused, and completion not dialing even when a reachable relay is on the line. The env-vs-reject test moved toargs.rs.just checkpasses.Impact
moq lsis an unknown command, with no alias.moq announcedreplaces it, and--followis gone because following is now the only mode. Scripts only need to changels --followtoannounced.terminal_size(moq-cli),vt100(moq-cli dev).moq-msfdev-dependency removed.Alternatives
Livewas exact.Decisions
Livegone it can briefly show an empty or partial list while the initial set arrives.(N more)line rather than scrolled or paged (from the Codex review).Follow-ups
lshad the same issue). Escape non-printables inView.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code