Repository navigation
fix(json): refuse a stream record past the group budget without ending the log #4911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5682828
quest: claim json-stream-budget
kixelated 0a8cbc7
fix(json): refuse a stream record past the group budget without endin…
kixelated a0ca767
docs(moq-mux): rewrap json::Stream::append doc
kixelated c9ad1f1
test(json): check the DEFLATE bound against pako, cover a spent budge…
kixelated ffa6425
Merge remote-tracking branch 'origin/main' into iterate/json-stream-b…
kixelated cbb5a58
chore: merge main into JSON stream budget
kixelated f802ca9
quest: remove completed JSON stream prerequisite
kixelated a06e2ce
chore: preserve reviewed JSON stream budget changes
kixelated 9e39fa8
chore: integrate completed Live removal into JSON budget
kixelated b0a55b8
docs: qualify missing track refusal by handler state
kixelated 4c60374
chore: integrate main for JSON budget merge
kixelated 0fdef2c
test(net): use maxDelay in finished cache regression
kixelated 98608f1
test(net): start handler before querying on-demand track
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Account for pending uncompressed records in the budget.
If a caller encodes two uncompressed records before committing either one, both checks use the same committed budget. For example, two 20 MiB records can pass preflight, but writing the second exceeds the 32 MiB group limit and aborts the log. Reserve budget for pending records, or require each pending record to settle before the next
encode.🤖 Prompt for AI Agents