Skip to content

quest: drop the JS qmux clean-finish check - #4957

Merged
kixelated merged 2 commits into
mainfrom
quest/m1/transport-upgrade/js-qmux-finish
Oct 7, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m1/transport-upgrade/js-qmux-finish

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

The Rust qmux crate reported every finished send stream as connection closed (fixed in moq-dev/web-transport#402). This quest asked whether the TypeScript peer does the same, and whether @moq/net would treat a delivered GOAWAY or SETUP as a failure over the WebSocket fallback.

Approach

It does not. @moq/qmux 0.3.3 (what js/net depends on; npm gitHead 9c70649, and the same close path as current web-transport main) fulfills both writer.close() and writer.closed after a clean FIN. The sink awaits the FIN onto the socket, then returns. A peer STOP_SENDING still errors the writable.

Checked against the published package: the existing "sequential stream writes and FIN" test, plus a uni stream closed with no payload and a bidi stream closed after one write. All three fulfill writer.closed and put fin: true on the wire.

@moq/net would not treat SETUP or GOAWAY as that failure today even if closed rejected. Lite #sendSetup writes the message and calls Writer.close(), which swallows a close rejection and does not await closed. Nothing in js/net sends a GOAWAY yet. Paths that do await writer.closed after a clean finish (announce withdrawal, SUBSCRIBE_NAMESPACE, PUBLISH_NAMESPACE) would see a fulfillment, not an error.

No release and no @moq/qmux bump. The quest is deleted, and its links are removed from the transport-upgrade line and the JavaScript upgrade quest.

Impact

  • Public API: none.
  • Wire: none.

Alternatives

  • Add a regression test in moq-dev/web-transport that asserts writer.closed fulfills. The existing FIN test already awaits writer.close(), which settles the same way, and the published package does not have the bug. Left it.
  • Change @moq/net to await closed on SETUP. Out of scope; there is no failure to fix, and sending GOAWAY belongs to the JavaScript upgrade quest.

Follow-ups

None. The JavaScript upgrade can await the GOAWAY stream's closed on the WebSocket fallback; @moq/qmux already reports that as a clean close.

(Written by Grok 4.7)

kixelated and others added 2 commits October 6, 2026 23:14
Co-Authored-By: Grok 4.7 <noreply@x.ai>
Co-Authored-By: Grok 4.7 <noreply@x.ai>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Outcome: the bug is not in @moq/qmux 0.3.3. A clean send FIN fulfills writer.closed (uni with no payload, and bidi after one write), and @moq/net does not await that promise for SETUP or GOAWAY. Quest deleted. No package release.

(Written by Grok 4.7)

@kixelated
kixelated marked this pull request as ready for review October 7, 2026 15:45
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2b491fdd-6fd0-4a5c-9565-5c8b3e57c721
📥 Commits

Reviewing files that changed from the base of the PR and between 0a7ab98 and 431b24d.

📒 Files selected for processing (3)
  • quest/m1/transport-upgrade/README.md
  • quest/m1/transport-upgrade/js-qmux-finish.md
  • quest/m1/transport-upgrade/js.md
💤 Files with no reviewable changes (3)
  • quest/m1/transport-upgrade/js-qmux-finish.md
  • quest/m1/transport-upgrade/README.md
  • quest/m1/transport-upgrade/js.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The JS qmux finish quest document was deleted. Its entries were also removed from the Required lists in the transport-upgrade README and JavaScript quest document. No code changes are described.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 431b2

This documentation cleanup appears mergeable after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that the JS qmux clean-finish quest check was removed. It matches the main change.
Description check ✅ Passed The description explains the clean FIN findings, the affected quest documents, and the absence of code, API, or wire changes. It is related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Automated review: quest: drop the JS qmux clean-finish check

Docs-only. It deletes quest/m1/transport-upgrade/js-qmux-finish.md and its two Required links (transport-upgrade/README.md, transport-upgrade/js.md). No code, wire, or API change.

I spot-checked the conclusion against the head source:

  • js/net/package.json depends on @moq/qmux ^0.3.3, the version the PR body says it checked.
  • Writer.close() in js/net/src/stream.ts:783-784 is this.#writer.close().catch(() => void 0), and lite #sendSetup (js/net/src/lite/connection.ts:231-237) calls that and never awaits closed. So even a rejecting closed would not surface as a SETUP failure today, as the PR says.
  • The remaining links to the deleted file are the two lines this PR removes. The Quest link check passes.

No issues found. One small point: the next person to touch the GOAWAY path won't find this verification in the repo. It survives only in the PR description, so the js.md GOAWAY step could link to this PR. That's optional.

CI: green (Check, Test, Quest pass; Auto-merge and Land back-merge skipped).

Verdict: MERGE (reviewed head 431b24d8)

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging per the maintainer's /quest-merge call.

  • Review: CodeRabbit reviewed head 431b24d8 with no actionable comments; the automated Grok review also found no issues.
  • The optional suggestion to link the js.md GOAWAY step to this PR is left out: the verification lives in this PR's description, and quests describe current plans rather than history.
  • Merged current main locally and quest check passes (no remaining references to js-qmux-finish.md).
  • No follow-ups.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit 58711a3 into main Oct 7, 2026
5 checks passed
@kixelated
kixelated deleted the quest/m1/transport-upgrade/js-qmux-finish branch October 7, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant