Repository navigation
fix(net): skip the empty namespace for foreign draft-14 and draft-15 peers #5018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0406026
fix(net): skip the empty namespace on draft-14 and draft-15
kixelated c258166
Merge remote-tracking branch 'origin/main' into m5018-land
kixelated b8424b3
fix(net): still ask a soliciting peer for the empty namespace
kixelated 7fe9d3d
Merge remote-tracking branch 'origin/main' into m5018-land
kixelated 865511b
quest: finish ietf-d14-root-prefix, document the d14 discovery gap
kixelated f066a4f
fix(js): end an unasked announcement reader with its session
kixelated d2caba6
Merge remote-tracking branch 'origin/main' into pr-5018
kixelated 0687cdf
Merge remote-tracking branch 'origin/main' into pr-5018
kixelated 4609def
Merge remote-tracking branch 'origin/main' into pr-5018
kixelated c307fa0
Merge remote-tracking branch 'origin/main' into pr-5018
kixelated 0a6a263
fix(net): update the empty-namespace test for main's session limits a…
kixelated b205748
Merge remote-tracking branch 'origin/main' into pr-5018
kixelated 8c7be13
test(net): declare Solicit in the draft-14 GOAWAY announce test
kixelated 0a06f64
Merge remote-tracking branch 'origin/main' into pr-5018
kixelated da29e6b
Merge remote-tracking branch 'origin/main' into pr-5018
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] End skipped announcement readers when the session closes
For a draft-14/15 peer with no Solicit declaration, this wait has no connection-lifetime signal. No request stream exists to wake it on disconnect;
Subscriber.close()only sets#localClose, andConnection.#close()only closes the transport/adapter. Consequently, afterconn.abort()or a remote disconnect, a directconn.announced()reader's pendingnext()andclosedremain unsettled, and the producer stays registered until the caller explicitly closes it. Callers using stream termination for cleanup/reconnection can hang.forwardAnnouncedcloses its own reader onconn.closed, but that only protects theconsumewiring. Race this wait against session/transport closure, or close these producers during all connection teardown paths, and add a local/remote-close regression test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in f066a4f: the skipped-request wait now races
announced.closedagainst the transport'sclosed, so the reader ends on a local or remote close. Regression tests cover both sides and fail without the fix.(Written by Claude Opus 5.5)