Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions quest/m1/js-request-deadline.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,19 @@ Decided 2026-10-07, re-planning the external
`js/net/src/stream.ts`) stays the default for `Stream.open` and
`Writer.open`, which SETUP, probe, and group streams inherit. Request sites
opt out of it, and their setup timer (`SUBSCRIBE_SETUP_TIMEOUT_MS` in lite,
`SUBSCRIBE_OK_TIMEOUT_MS` in IETF, PUBLISH_NAMESPACE's own) covers the
`SUBSCRIBE_OK_TIMEOUT_MS` in IETF, and PUBLISH_NAMESPACE's
`ADVERTISE_TIMEOUT_MS`, which moves from 5 s to the shared 10 s) covers the
create as well as the answer.
- PUBLISH_NAMESPACE is in scope with no retry: drop the IETF publisher's loop
that re-offers a failed advertisement.
- PUBLISH_NAMESPACE is in scope with no retry: both loops that advertise
through `#advertise` (`runPublishNamespaces` and the draft-14/15 solicited
`#runSubscribeNamespace`, `js/net/src/ietf/publisher.ts`) stop re-offering
after either failure above. Both failures return `"dropped"` today, the
answer that keeps the backoff running, so they need their own terminal
answer. The namespace then stays unadvertised through that peer until it is
republished or the session reconnects. Each loop still re-offers when the
peer's REQUEST_ERROR names a retry interval, and keeps its backoff for a
draft-14/15 refusal, which can't carry one (decided 2026-10-07 from review:
the peer asked for those). Test both loops.
- The credit error is local, with no wire code. Propose its name in the PR;
it is a new public `@moq/net` error.
- `@moq/watch` keeps ending a track on either failure. Rejected: #4999's
Expand Down
13 changes: 9 additions & 4 deletions quest/m1/rs-request-credit.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,17 @@ leaves, or the session closes, and a relay shouldn't kill a subscribe on a
slow upstream hop.

A single `Pending` poll of `open_bi` is not "no credit": on WebTransport,
`web-transport-quinn` opens the QUIC stream and then writes the session header,
`web-transport-moq` opens the QUIC stream and then writes the session header,
which can be pending under send-window pressure. Check credit at the QUIC
level instead, likely a non-waiting open on the transport trait. Also note that
level instead, likely a non-waiting open on moq-net's `transport::poll`
session trait. Also note that
`moq-tokio`'s `poll_open_bi` parks an abandoned open in the session's slot
rather than dropping it, so the next request inherits it; the non-waiting open
should avoid that.
should avoid that. The async backends `moq-tokio` wraps (qmux, iroh, noq) have
no credit query in `web-transport-trait`, which `moq-tokio` needs to
implement that method for them; prefer adding one upstream in
moq-dev/web-transport over leaving them waiting, and say in the PR which
backends fail fast.

Propose the error variant's name in the PR. Public API: one new `Error`
variant, and possibly a transport-trait method. Wire: none.
variant, and possibly a `transport::poll` session method. Wire: none.
Loading