Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions quest/m1/qos/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,16 @@ This line only reports the counters.

Decided (2026-10-06 audit): [stats totals and prefix
tracks](/quest/m0/broadcast-epoch/stats-split.md) lands first, since it is m0
and gates the release; #4133 rebases its histograms onto stats-split's totals
and prefix tracks rather than the per-path `publisher.json` and
`subscriber.json` map rows it writes today, which stats-split retires.
Rejected: #4133 first, which would make stats-split carry the lag histogram
and dropped counters across.
and gates the release; the lag histogram lands on stats-split's totals and
prefix tracks rather than the per-path `publisher.json` and
`subscriber.json` map rows, which stats-split retires.
Rejected: the histogram first, which would make stats-split carry the lag
histogram and dropped counters across.

Decided (2026-10-08): the egress histogram is its own quest,
[viewer lag histogram](/quest/m1/qos/lag-histogram.md), since every other
child reads it and it exists only on the line branch.
child reads it. The line's PR, #4133, closed without landing (2026-10-09);
its code is kept on `wip/4133-lag-histogram`.

Decided (2026-09-28): the line's moq-stats changes break the published
crate. Client stats left the line (2026-09-29)
Expand Down
40 changes: 33 additions & 7 deletions quest/m1/qos/lag-histogram.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,39 @@ last partial interval.
## Plan

Decided 2026-10-08: split out of the QoS line so the dashboard and publisher
timeliness can require a histogram that exists on `main`. The implementation
already lives on the line branch
([#4133](https://github.com/moq-dev/moq/pull/4133)): the sampler (#4298,
`rs/moq-net/src/stats.rs`), the splice fixes (#5009), and the final sample
(#4451). This quest lands it on `main` once stats-split has, rebased from the
per-path `publisher.json` and `subscriber.json` map rows it writes today onto
stats-split's totals and prefix tracks.
timeliness can require a histogram that exists on `main`. This quest lands it
on `main` once stats-split has, moved from the per-path `publisher.json` and
`subscriber.json` map rows it writes today onto stats-split's totals and
prefix tracks.

Decided 2026-10-09: the QoS line
([#4133](https://github.com/moq-dev/moq/pull/4133)) closed without landing,
since every code change it had over `main` is this histogram. Its code is kept
on `wip/4133-lag-histogram` as this quest's starting point: the sampler
(#4298, `rs/moq-net/src/stats.rs`), the splice fixes (#5009), and the final
sample (#4451). Porting it is not mechanical:

- `main` moved to caller-supplied time (#4437) and removed the frozen test
clock (`model::clock::advance`). The sampler reads wall time in
`Registry::report`, when a `Frontier` opens, on `Delivery` acks, and in the
final sample in `Drop for FrontierInner`, which has no caller to supply a
time. Redesign those to take time from their callers, and give the final
sample an explicit close path.
- Untimed tracks (#4822): record `Production` only for timed frames.
- `max_age` became `max_delay` on subscriptions (#4917).

Open review findings on #4133 to fix while porting:

- A timestamp regression hides a stalled viewer
([3](https://github.com/moq-dev/moq/pull/4133#issuecomment-6053929743)).
- A copy served across a no-route gap stays watched
([B](https://github.com/moq-dev/moq/pull/4133#issuecomment-6053929743)).
- A partial write is charged the frame's full declared size
([P2](https://github.com/moq-dev/moq/pull/4133#pullrequestreview-5452586850)).
- `Dropped::add` should saturate instead of overflowing
([comment](https://github.com/moq-dev/moq/pull/4133#discussion_r4215691174)).
- Bound the frontier list when `Registry::report` is not called
([comment](https://github.com/moq-dev/moq/pull/4133#discussion_r4215691184)).

Keep the histogram contract the dashboard reads: buckets keyed by upper edge
(`"50ms"` to `"5s"`, then `"inf"`, empty buckets omitted), cumulative and
Expand Down
7 changes: 4 additions & 3 deletions quest/m1/quest-flat-lines.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,10 @@ Remaining:
pin from `.2`, then check `OBS (macOS)`.
- #4519 ffi-shape waits on
[Bindings](/quest/m0/broadcast-epoch/bindings.md).
- #4133 qos: lag-splice landed on the line (#5009). Its egress `lag`
histogram splits into its own quest requiring stats-split (decided
2026-10-08); follow the qos README for what the line lands without it.
- #4133 qos: closed without landing (2026-10-09). Every change it had over
`main` is the egress `lag` histogram, which
[Viewer lag histogram](/quest/m1/qos/lag-histogram.md) ports from the
branch once stats-split lands.

Done when `flake.nix` pins the new quest, no `quest/*README` branch remains,
and `quest check` passes.
Loading