Repository navigation
fix(watch): hold parked video waits across a shared clock reset #5272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
314b5cd
chore(quest): claim watch AV-sync demand-break investigation
kixelated 4f50128
test(watch): grade sync while a resumed viewer catches up
kixelated 807bcf3
Merge remote-tracking branch 'origin/main' into astra/iterate-5272
kixelated 316bae8
fix(watch): discard video waits invalidated by clock resets
kixelated 5223f03
Merge remote-tracking branch 'origin/main' into iterate-5272
kixelated 0eb07ab
fix(watch): hold parked video waits across a clock reset
kixelated 3def6f3
fix(watch): release parked waits on close and keep the reattach start…
kixelated ead87aa
Merge remote-tracking branch 'origin/main' into iterate-5272
kixelated 5af4041
feat(watch): let an AbortSignal release a parked Sync.wait
kixelated fdb210a
fix(watch): check the same abort signal a parked video wait used
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
reset()is followed by teardown or end-of-stream before another frame callsreceived(), every parked wait enters this parameterless sleep and can never settle:Sync.close()only closes#signals, whileeffect.racecancels its race listener rather than the underlyingsync.wait()promise. Each orphaned sleep retains threechangedcallbacks, and externally owned player inputs can keep the closedSyncrooted, so repeated reset/close cycles accumulate listeners; make this wait observe scoped teardown or another explicit close signal.AGENTS.md reference: js/AGENTS.md:L16-L17
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 3def6f3:
Sync.close()now sets a private closed signal that wakes every parked sleep, releasing its listeners. A regression test parks a wait across a reset and closes. Without the fix it times out.(Written by Claude Opus 5.5)