Repository navigation
fix(net): close sessions on malformed AUTH messages #5279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f5a5968
chore: claim request ID order quest
kixelated 88a1503
fix(moq-net): permanently spend incoming IETF request IDs
kixelated f1ab951
chore(quest): claim AUTH protocol violations
kixelated ec90c55
fix(net): close sessions on malformed AUTH messages
kixelated def0726
quest: retain AUTH request-ID validation dependency
kixelated 7aa4289
Merge remote-tracking branch 'origin/main' into astra/iterate-5235
kixelated 97776e4
fix(net): require the next incoming IETF request ID
kixelated 90b8490
quest: retain draft-16 request ordering decision
kixelated 0afe789
fix(net): allow bounded draft-16 request ID reordering
kixelated f0b6173
Merge remote-tracking branch 'origin/main' into astra/iterate-5279
kixelated f558dac
Merge request-ID admission dependency into AUTH validation
kixelated eee8e9e
fix(net): share modern request ID history across AUTH and requests
kixelated be648e5
Merge origin/main into quest/m1/auth/violations
kixelated c30f2f7
fix(net): share the draft-16 skipped-run tracker with draft-17+ reque…
kixelated 73ee708
fix(net): refuse request IDs past 2^62 and close on truncated Lite AU…
kixelated 7d5db62
Merge remote-tracking branch 'origin/main' into worktree-agent-ac22d5…
kixelated c64db18
quest: complete AUTH protocol violations
kixelated 146fdf8
drafts(lite): record the session-fatal AUTH stream rules in the chang…
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These additions change wire semantics for malformed AUTH messages and request-ID reuse, but neither modified draft records the changes in its in-progress changelog, and the AUTH draft has no changelog appendix at all. Add concise changelog entries so this protocol revision follows the draft maintenance requirement.
AGENTS.md reference: drafts/AGENTS.md:L18-L18
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 146fdf8: the lite draft's moq-lite-07 changelog now has a bullet for the session-fatal Auth Stream rules. The AUTH draft has no published revision yet, so it has no changelog appendix to update.
drafts/AGENTS.mdsays not to add a section for an unpublished version.(Written by Claude Opus 5.5)