Repository navigation
quest(m1): plan subscription order and a live largest location - #5379
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eff3c3acca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - **One name everywhere.** Rename on the producer, consumer and subscriber, | ||
| and update every caller (moq-json, moq-flate, moq-mux, moq-relay, moq-hls, | ||
| moq-c, and the rest) in the same PR. JS's buffered-only `largest()` takes | ||
| the new meaning. Callers that read `latest()` synchronously today, such as | ||
| producers picking their next sequence, are the risk of stream only; if one |
There was a problem hiding this comment.
Preserve the sequence high-water query
When the highest sequence belongs to a datagram or an empty group, a frame-based Location cannot replace latest(): the current TrackState::max_sequence advances for both, and callers such as moq-json use latest() + 1 to select the next group. Following this rename literally would either wait forever for a frame or derive an already-used sequence. Keep a distinct synchronous sequence high-water API, or explicitly migrate every such caller to an authoritative sequence allocator rather than replacing it with the largest() stream.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed on the problem, fixed the plan in e91684a using your second option. max_sequence counts datagrams and frameless groups, so producers that allocate with latest() + 1 (moq-json, moq-mux) can't read it from a frame Location; the quest now moves them to the track's own allocator (append_group), and routes any that can't (such as moq-mux skipping a sequence on a data-track discontinuity) to the maintainer.
Declining the first option, a separate synchronous sequence high-water API: the maintainer decided largest() is stream only with no snapshot, so adding one is their call, which the quest already says to ask for.
(Written by Claude Opus 5.5)
…gest() Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eff3c3a to
e91684a
Compare
|
Merge summary for e91684a:
(Written by Claude Opus 5.5) |
Summary
Plans two m1 quests from the API review of two contributor drafts:
quest/m1/subscribe-ranges/order.md[L]:Subscription.order(Order::Ascending | Descending, default descending) split out of Model ranges so it lands now, built on the feat(moq-net): let a subscriber choose the SUBSCRIBE group order #5370 commit with credit. The track cursor serves each subscriber in its order; moq-transport GROUP_ORDER and lite-07 SUBSCRIBE carry it.quest/m1/largest.md[M]:largest()replaceslatest()on the track producer, consumer and subscriber in Rust and JS, as a live stream of the largestLocation, seeded by SUBSCRIBE_OK / SUBSCRIBE_START. Replaces feat(moq-net): carry SUBSCRIBE_OK Largest Location to the consumer #5369'sInfo.publisherLargestsnapshot.Model, epic and JS ranges quests updated to point at the order quest. Public API: none (plans only). Wire: none.
Decisions
#5370: what to do with the GROUP_ORDER codec field? (internal, unset, unhonored)
Subscription.ordernow in a new PR built on it, crediting the contributorOrder scope
Live edge shape
latest()largest(): Locationlatest()tolargest(), poll/async/signal basedPriority
Edge type
LocationRename scope
Edge API
Stream semantics
Order merge upstream
Older wires (lite-06 and earlier)
Name
OrderGroupOrder(Written by Claude Opus 5.5)
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.