Skip to content

quest(m1): plan subscription order and a live largest location - #5379

Merged
kixelated merged 2 commits into
mainfrom
quest/plan-order-and-largest
Oct 13, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/plan-order-and-largest

Conversation

@kixelated

@kixelated kixelated commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Plans two m1 quests from the API review of two contributor drafts:

Model, epic and JS ranges quests updated to point at the order quest. Public API: none (plans only). Wire: none.

Decisions

#5370: what to do with the GROUP_ORDER codec field? (internal, unset, unhonored)

  • Close with thanks
  • Land tightened as an internal codec step
  • Ask the contributor
  • ✅ Implement Subscription.order now in a new PR built on it, crediting the contributor

Order scope

  • ✅ Model + IETF + lite-07
  • Model + IETF only
  • Don't split

Live edge shape

  • Extend latest()
  • New largest(): Location
  • ✅ Rename latest() to largest(), poll/async/signal based
  • Defer

Priority

  • ✅ Both m1
  • Order m1, edge m2
  • Both m2

Edge type

  • ✅ Location
  • Group sequence

Rename scope

  • ✅ Everywhere (producer, consumer, subscriber; Rust and JS)
  • Subscriber side only

Edge API

  • Snapshot + wait
  • ✅ Stream only

Stream semantics

  • ✅ Coalesced: current at once, then each newer, ends with the track
  • Every advance

Order merge upstream

  • ✅ Descending wins
  • Ascending wins
  • Separate requests

Older wires (lite-06 and earlier)

  • Refuse
  • ✅ Fall back to descending

Name

  • ✅ Order
  • GroupOrder

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T01:15:26.507149Z eff3c3a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5409e51e-9ac8-4142-85af-058b428d40f6
📥 Commits

Reviewing files that changed from the base of the PR and between 7a94840 and e91684a.

📒 Files selected for processing (6)
  • quest/m1/README.md
  • quest/m1/largest.md
  • quest/m1/subscribe-ranges/README.md
  • quest/m1/subscribe-ranges/js.md
  • quest/m1/subscribe-ranges/model.md
  • quest/m1/subscribe-ranges/order.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eff3c3acca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/largest.md Outdated
Comment on lines +23 to +27
- **One name everywhere.** Rename on the producer, consumer and subscriber,
and update every caller (moq-json, moq-flate, moq-mux, moq-relay, moq-hls,
moq-c, and the rest) in the same PR. JS's buffered-only `largest()` takes
the new meaning. Callers that read `latest()` synchronously today, such as
producers picking their next sequence, are the risk of stream only; if one

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the sequence high-water query

When the highest sequence belongs to a datagram or an empty group, a frame-based Location cannot replace latest(): the current TrackState::max_sequence advances for both, and callers such as moq-json use latest() + 1 to select the next group. Following this rename literally would either wait forever for a frame or derive an already-used sequence. Keep a distinct synchronous sequence high-water API, or explicitly migrate every such caller to an authoritative sequence allocator rather than replacing it with the largest() stream.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on the problem, fixed the plan in e91684a using your second option. max_sequence counts datagrams and frameless groups, so producers that allocate with latest() + 1 (moq-json, moq-mux) can't read it from a frame Location; the quest now moves them to the track's own allocator (append_group), and routes any that can't (such as moq-mux skipping a sequence on a data-track discontinuity) to the maintainer.

Declining the first option, a separate synchronous sequence high-water API: the maintainer decided largest() is stream only with no snapshot, so adding one is their call, which the quest already says to ask for.

(Written by Claude Opus 5.5)

kixelated and others added 2 commits October 12, 2026 18:18
Split `order` out of the model-ranges quest so it can land now on the
contributor's #5370 commit, and plan `largest()` replacing `latest()` as a
live stream seeded by the publisher's reported largest, instead of #5369's
Info snapshot.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…gest()

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated force-pushed the quest/plan-order-and-largest branch from eff3c3a to e91684a Compare October 13, 2026 01:18
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary for e91684a:

  • Plans quest/m1/subscribe-ranges/order.md [L] (Subscription.order, built on feat(moq-net): let a subscriber choose the SUBSCRIBE group order #5370 with credit) and quest/m1/largest.md [M] (largest() replaces latest() as a live Location stream), with the maintainer's decisions in the body unchanged.
  • Rebased onto main after quest(m1): plan MoQT own-range codes and relay drain from web accept #5374 (both touch quest/m1/README.md); no conflict.
  • Codex P1 (sequence high-water vs a frame Location): fixed with its second option. Producers that allocate with latest() + 1 move to the track's allocator (append_group), and any that can't go to the maintainer. Declined its first option, a separate synchronous sequence API, since the maintainer chose stream only with no snapshot.
  • CodeRabbit was rate-limited on both heads; the Codex review of eff3c3a covers this head, which drew no new review after CI.
  • quest check passes; CI is green.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit 1009b00 Oct 13, 2026
4 checks passed
@kixelated
kixelated deleted the quest/plan-order-and-largest branch October 13, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant