Repository navigation
fix(net): queue a prefix retracted again at one clock reading once - #5391
Conversation
Retract and announce cycles between clock readings each queued an anchoring entry, so a cursor that never went pending grew the queue with churn instead of prefixes. A delivered announcement now leaves the quarantine to expire, since later announcements are updates it never holds, and a retraction at the same reading skips the queue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An anonymous retraction removed the prefix's quarantine, so a named retraction after it at the same reading queued again. Keep the entry with no publisher instead, which holds nothing but still marks the prefix as queued. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 61c7ac2
No actionable findings in the full one-file diff. The same-reading queue deduplication now survives alternating named/anonymous retractions, addressing the remaining issue identified in #5376. Publisher-less markers hold no routes, and the regression test covers that alternating sequence and eventual quarantine cleanup.
Direction: focused fix that reuses existing per-prefix state without introducing queue scans or changing the API/wire format.
Verification: static review of the patch and surrounding announcement/coalescing, quarantine, and timer paths. Tests and benchmarks were not run; the reported just check result was not independently reproduced.
Problem
#5375's retraction quarantine queues each retraction until the next clock reading. A delivered announcement removed the quarantine but left its queue entry, so retract and announce cycles before the clock moved each added one. A cursor that never went pending (synchronously drained, or always ready) grew the queue with route churn instead of with prefixes. Found by Codex on the release backport, #5376.
Approach
a_retraction_quarantines_a_named_publishernow cycles one prefix four times at one reading, alternating named and anonymous routes, and asserts a single queue entry for it.Impact
Alternatives
Follow-ups
release.Checks
just checkpasses (6156 tests).🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Need help on this PR? Tag
@codesmith-botwith what you need.