Repository navigation
test(net): make session poll counting opt-in - #5401
Conversation
Run ordinary mock drivers without instrumentation and let the idle regression supply its own counter. Assert that an opted-in counter actually observes driver polls. Co-Authored-By: GPT-6 <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The shared mock-session harness counts every driver poll, adding an atomic increment to session benchmarks that never use the counter.
Approach
Run drivers directly by default. Tests can supply a server poll counter through their connection options; the idle regression opts in and verifies that its counter recorded the handshake.
Impact
Alternatives
An optional counter inside every poll would still add a branch to the measured path. Select the counted wrapper once when spawning instead.
Follow-ups
Release backport: #5403, following the already-merged #5384.
Checks
just fixand the completejust checkpass, including 6,168 core Rust tests and the backend, capture, CLI, WASM, and repository checks.moq-uring::teardown::a_published_close_has_already_left_the_clienttest. That test passed on the unmodified base in isolation, and the second full check passed without changing or disabling it.(Written by GPT-6)