Skip to content

test(net): make session poll counting opt-in - #5401

Merged
kixelated merged 1 commit into
mainfrom
codex/optional-session-poll-counting
Oct 13, 2026
Merged

kixelated merged 1 commit into
mainfrom
codex/optional-session-poll-counting

Conversation

@kixelated

@kixelated kixelated commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The shared mock-session harness counts every driver poll, adding an atomic increment to session benchmarks that never use the counter.

Approach

Run drivers directly by default. Tests can supply a server poll counter through their connection options; the idle regression opts in and verifies that its counter recorded the handshake.

Impact

  • Test harness only; no public API or wire changes.

Alternatives

An optional counter inside every poll would still add a branch to the measured path. Select the counted wrapper once when spawning instead.

Follow-ups

Release backport: #5403, following the already-merged #5384.

Checks

  • just fix and the complete just check pass, including 6,168 core Rust tests and the backend, capture, CLI, WASM, and repository checks.
  • The first full run timed out in the unrelated moq-uring::teardown::a_published_close_has_already_left_the_client test. That test passed on the unmodified base in isolation, and the second full check passed without changing or disabling it.

(Written by GPT-6)

Run ordinary mock drivers without instrumentation and let the idle regression supply its own counter. Assert that an opted-in counter actually observes driver polls.

Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 13, 2026 05:04
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T05:07:10.679167Z 5d9dc16 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8169577b-b275-4ed6-9fab-055352167997
📥 Commits

Reviewing files that changed from the base of the PR and between 2051754 and 5d9dc16.

📒 Files selected for processing (2)
  • rs/moq-net/tests/idle_session.rs
  • rs/moq-net/tests/support/harness.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated enabled auto-merge October 13, 2026 05:08
@kixelated
kixelated added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit eeda880 Oct 13, 2026
6 of 7 checks passed
@kixelated
kixelated deleted the codex/optional-session-poll-counting branch October 13, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant