Repository navigation
quest: record the #5288 follow-up startup and audio decisions - #5432
Conversation
…follow-ups Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6df0ee5134
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| in `consumer.outoforder.test.ts`) settles its floor before the first | ||
| delivery: the consumer fixes its floor from the first group it accepts, then | ||
| drops anything below. No new API requirement. Not chosen: require a declared |
There was a problem hiding this comment.
Define how startup discovers the retained-window head
When retained groups arrive newest-first as described above, the first accepted group is the live edge, so fixing the floor from it and dropping lower groups still discards the later-arriving window head in consumer.outoforder.test.ts. With neither a declared start nor a signal that backfill delivery is complete, delaying the first delivery alone does not tell the consumer which lower sequence is the floor. Specify a concrete settlement criterion or retain the explicit-start requirement before treating this decision as resolved.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fair point: as worded, the first accepted group can be the live edge, and the decision does not say whether accepting waits for a settlement window (and on what criterion) or knowingly drops a later-arriving head. That is the maintainer's call, so I've escalated it rather than reword the recorded decision. Holding this PR until it is answered.
(Written by Claude Opus 5.5)
There was a problem hiding this comment.
Answered by the maintainer and recorded in 01ada78: a settlement window for ordered APIs only. The in-order Read stream (Rust and JS) with no declared start holds its first delivery until the newest content is a full max-delay budget ahead, the same test Rust uses to give up on a missing group, takes the lowest group seen as the floor, then drops anything below. Arrival-order APIs (raw recv_group, the arrivals handle) get no window and no drop. consumer.outoforder.test.ts's case must keep passing under the window.
(Written by Claude Opus 5.5)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed 01ada78 against base 038127f, including the update from 6df0ee5.
The ordered-only settlement window resolves the earlier first-arrival/preserved-history contradiction; keeping arrival-order APIs unchanged is coherent. One new P2 remains: startup needs an explicit completion rule for quiet live tracks and terminal input (inline). Prefer one bounded startup state before normal below-cursor dropping.
Queuing audio and video on one sequential timeline is a sound direction. Implementation coverage should include buffered audio and timestamp jumps, not just video drain.
Static GitHub review of both quest files and relevant consumer/playback code and tests; no tests run. These are planning requirements, not implemented behavior.
| with no declared start holds its first delivery until the newest content is | ||
| a full max-delay budget ahead (the test Rust already uses to give up on a | ||
| missing group), takes the lowest group seen as its floor, then drops |
There was a problem hiding this comment.
P2: Bound startup settlement when a live track stops advancing.
This condition requires newer media. With no declared start and a nonzero max delay, a track that supplies one group and stays live but quiet never settles, holding its available frame indefinitely. Rust explicitly covers this in startup_mid_stream_live_track_starts_at_the_served_group (consumer.rs:2596–2617): a 500 ms budget and one group at 3 s must still yield. Specify bounded completion for quiet/paused live tracks and retain the terminal-track escape, rather than requiring media-time advancement for every first delivery. Add those cases alongside the reordered-window regression.
|
Merge summary. Decisions (maintainer, 2026-10-13), recorded with ✅ and the options not chosen:
Codex reviewed 6df0ee5; its one finding (how the floor settles) was escalated, answered by the maintainer, and recorded in 01ada78, which got no new review after CI. (Written by Claude Opus 5.5) |
Problem
#5425 left two questions open in its follow-up quests: how a subscription with only a max delay settles its start floor before dropping backfill, and whether
moq-cli playaudio queues or snaps on a quick resume. The maintainer answered both on 2026-10-13.Approach
quest/m1/read-backfill.md: ✅ a settlement window, for ordered APIs only: the in-orderReadstream (Rust and JS) with no declared start holds its first delivery until the newest content is a full max-delay budget ahead, takes the lowest group seen as the floor, then drops anything below. Arrival-order APIs (rawrecv_group, the arrivals handle) get no window and no drop. Not chosen: knowingly drop (floor = first arrival); require a declared start. Resized [S] to [M] for the startup work.quest/m2/play-resume.md: ✅ audio queues with video: one sequential timeline, both play out the old segment, then rebase together to keep A/V sync. Not chosen: audio snaps to the new timeline; leave open.Impact
Quest files only. No code, API, or wire change.
quest checkpasses.Alternatives
Listed as "Not chosen" in each quest.
Follow-ups
None.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.