Skip to content

quest: plan the #5446 and #5447 follow-ups - #5450

Merged
kixelated merged 3 commits into
mainfrom
claude/plan-panic-flake-followups
Oct 13, 2026
Merged

kixelated merged 3 commits into
mainfrom
claude/plan-panic-flake-followups

Conversation

@kixelated

@kixelated kixelated commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Plans follow-ups from #5446 (resume duplicates) and #5447 (panic isolation).

  • quest/m1/test-flakes-2/auth-refresh-expiry.md [XS]: an_outage_refuses_transiently_and_never_extends_the_expiry measured 28.862 s against its 29 s floor under load, because the grant's wall-clock expiry loses any wall-time delay when converted onto the paused Tokio clock.
  • quest/m1/ffi-panic-supervision.md [M]: a panic in moq-c's or moq-ffi's other background tasks reaches the host as a panic, never a lost callback or Cancel; includes the accept-loop death regression Contain a panic to the session it happens in #5447 left out.
  • quest/m2/task-supervision.md [S]: the auth decider loop, stats publisher, and moq-tokio's token and WebSocket internals.

Decisions

Plan the flaky relay auth refresh test?

  • ✅ Yes
  • None

Plan which #5447 follow-ups?

  • ✅ Supervise moq-c + moq-ffi tasks
  • ✅ Remaining long-lived tasks
  • None

Binding panic supervision: which act?

  • m0
  • ✅ m1

Remaining long-lived tasks: which act?

  • ✅ m2
  • m1

Public API: none. Wire: none.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T20:13:06.228083Z 5867281 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 071a72f8-37c9-468d-9610-9bc4a50cbb62
📥 Commits

Reviewing files that changed from the base of the PR and between 5772da1 and 5867281.

📒 Files selected for processing: 6
  • quest/m1/README.md
  • quest/m1/ffi-panic-supervision.md
  • quest/m1/test-flakes-2/README.md
  • quest/m1/test-flakes-2/auth-refresh-expiry.md
  • quest/m2/README.md
  • quest/m2/task-supervision.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5867281950

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/ffi-panic-supervision.md Outdated
Comment on lines +28 to +29
Public API: none expected, beyond the panic error reaching more callbacks;
report any new error variant through the Cross-Package Sync table. Wire: none.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Plan the required binding synchronization

Because this quest necessarily changes rs/moq-ffi's host-visible error behavior, limiting Cross-Package Sync to cases that introduce a new error variant skips the required wrapper and documentation audit when the implementation reuses the existing MoqError::Task. That can leave Python, Swift, Kotlin, Dart, Go, C++, OBS, and their docs unverified or stale even though the goal promises that panics reach every host; make the downstream synchronization unconditional.

AGENTS.md reference: AGENTS.md:L100-L102

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed: a panic reaching more callbacks is host-visible even when it reuses an existing variant. efdad97 makes the moq-ffi Cross-Package Sync walk unconditional.

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: efdad97.

One P2 plan issue below: moving the test's start earlier does not remove the wall-clock/Tokio-clock mismatch under load. The narrow flake investigation and separate binding/process supervision work are sensible. The earlier binding synchronization finding is fixed by the unconditional wrapper/documentation audit. Binding origin supervision will need its own driver ownership rather than an outer wrapper around the process-aborting helper.

Verification: GitHub-only inspection of all six changed documents and relevant auth/binding code. No tests run; the reported 28.862-second failure was not independently reproduced.

Comment on lines +14 to +19
The test runs on a paused clock but takes `start` after `admission()` and
`sessions()`. The grant's 30 s starts at admission, and the paused clock
auto-advances whenever the runtime idles in between, so under load `start`
lands late and the measured life comes up short. Measure from the instant
the grant is admitted (take `start` before `admission()`, or read the
grant's own start), keeping the same bounds. Find what idles the runtime in

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Include the wall-to-monotonic clock conversion in the fix

The grant is created with SystemTime::now() + 30s (auth/refresh.rs:362), but Grant::deadline() computes tokio::Instant::now() + (expires - SystemTime::now()) (moq-auth/src/grant.rs:73–75), including when the refresh credential is constructed during session setup. A >1s wall-time scheduling delay can therefore leave <29s on the paused Tokio clock even if start is moved before admission(). sessions() uses an in-memory duplex, so checking only for real sockets will not catch this. Please include controlling this conversion or asserting against the actual captured expiry deadline, with a scheduling-delay regression, instead of prescribing the earlier start as sufficient.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, and it fits the numbers: a 1.14 s wall delay before the lease snapshots Grant::deadline() gives exactly 28.862 s on the paused clock. 17e9b16 names the clock mismatch as the cause, drops the earlier-start and real-socket guidance, and asks for a reproduction by delaying wall time before admission. I left the regression as a reproduction step rather than a separate test, since the fixed test itself covers it.

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 17e9b16, compared with efdad97.

The previous mixed-clock finding is fixed in the plan: it now accounts for wall-to-Tokio conversion, measures against the captured deadline or controls expiry construction, and requires a wall-delay reproduction. The earlier unconditional binding synchronization fix remains intact. No new actionable bugs found in this update; the revised investigation is appropriately focused.

Verification: GitHub-only review of the two changed documents against the previously inspected auth code. This is a plan correction, not an implemented runtime/test fix; no tests run.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging.

Review fixes:

  • Codex P2: the binding panic quest now walks the rs/moq-ffi Cross-Package Sync row unconditionally, since a panic reaching more callbacks is host-visible even without a new error variant (efdad97).
  • OpenAI P2: the auth refresh flake's cause is the grant's wall-clock expiry losing any wall-time delay when Grant::deadline() converts it onto the paused Tokio clock, not a late start. The quest now measures on one clock and reproduces with a wall-time delay before admission (17e9b16).

Decisions were settled interactively before this PR (see the body). #5447 is still open; the new quests cite it as a PR link and reuse its moq_tokio::panic, so they start after it lands.

Note for whoever picks up the binding quest: the OpenAI review points out that origin supervision needs its own driver ownership rather than an outer wrapper around the process-aborting helper.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit 4e3e23b Oct 13, 2026
3 checks passed
@kixelated
kixelated deleted the claude/plan-panic-flake-followups branch October 13, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant