Repository navigation
feat(net): JavaScript answers IETF TRACK_STATUS - #5468
Conversation
|
Quest outcome: implemented as planned in Local results:
Open note for review: a native reader that only fetches, against a JS publisher, now gets TRACK_STATUS_OK and then has its FETCH refused. Before, it fell back to SUBSCRIBE. The common case #5409 found, where a subscription follows right after the query, still subscribes. The FETCH gap belongs to (Written by Claude Opus 5.5) |
A @moq/net publisher answers TRACK_STATUS on every draft instead of refusing it NOT_SUPPORTED, mirroring the Rust publisher: the grant is checked first, the broadcast resolves through the serving origin, the answer waits on the track's info without subscribing, and a cancelled request releases its origin demand and track lookup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
addcbcf to
c8fdde6
Compare
|
Rebased on main. The maintainer chose to ship as is (✅ in the PR body). Local checks on the rebased head:
(Written by Claude Opus 5.5) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merge summary: a Decisions: ✅ ship as is, so a reader that only fetches from JS now gets TRACK_STATUS_OK and then a refused FETCH. JavaScript FETCH ( Review: Codex reviewed c8fdde6 with no findings. Every CI check passed. (Written by Claude Opus 5.5) |
A
@moq/netpublisher now answers IETF TRACK_STATUS on every draft instead of refusing it NOT_SUPPORTED. A native fetch-only request on drafts 14-16 and 18-22 learns the track in one round trip, with no SUBSCRIBE fallback. Draft 17 still subscribes, because its TRACK_STATUS_OK cannot say whether the track is timed (TrackStatusOk::describes_trackon the Rust side, unchanged).Mirrors
run_track_status_streaminrs/moq-net/src/ietf/publisher.rs:resolveTrackInfo), so the track is never subscribed.wire.Broadcast.largest(name)reads it without subscribing.Codec: the obsolete pre-draft-14
TrackStatusclass is replaced byTrackStatusOk, which mirrors Rust. On draft 14 it is the SUBSCRIBE_OK body with Track Alias 0 under type 0x0E. On later drafts it is REQUEST_OK with LARGEST_OBJECT, plus GROUP_ORDER on draft 15 and Track Properties from draft 18.TrackStatusRequestnow keeps INCLUDE_PROPERTIES. SUBSCRIBE and TRACK_STATUS share the broadcast resolution and refusal helpers, so the refusal bytes come from one place.Public API and wire impact
TrackStatusOk,TRACK_STATUS_ERROR_14, thecachedLargesthook, andwire.Broadcast.largestare package-internal.not found: broadcast <path>where it used to saybroadcast not found. The code is unchanged.doc/concept/standard.mdno longer lists JavaScript among the TRACK_STATUS refusals.Tests
js/net/src/ietf/publisher.test.ts, each run on every draft from 14 to 22:ietf.test.ts: TrackStatusOk round trip on every draft.ietf_track_status_interop, wired intojust test interop: Rust encodes TRACK_STATUS, the JS publisher answers throughtest/interop/track-status.ts, and Rust decodes the TRACK_STATUS_OK and the DOES_NOT_EXIST refusal the way its subscriber reads them, on drafts 14-22.just check,bun testin js/net, andjust test interop --all.Decisions
Follow-ups
quest/m1/js-fetch.mdnow says to check, once JS FETCH lands, whether the Rust IETF subscriber still needs to fall back to SUBSCRIBE on a NOT_SUPPORTED TRACK_STATUS, and to delete the fallback if no in-tree publisher refuses anymore.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Need help on this PR? Tag
@codesmith-botwith what you need.