Repository navigation
quest: settle the untimed follow-ups #5522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # [M] Untimed tracks are recorded and replayed untimed | ||
|
|
||
| ## Goal | ||
|
|
||
| `moq_archive::Writer` records a track with no timescale instead of refusing it | ||
| with `Error::Untimed`, so `moq export archive` works over moq-lite before 05 | ||
| and moq-transport without TIMESCALE (every track on drafts 14-16). | ||
| `moq_archive::Reader` replays such a track untimed: its frames carry no | ||
| timestamp, never a send or arrival time standing in for one. A frame missing | ||
| its timestamp on a timed track stays malformed. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-14 by the maintainer, from | ||
| [#4822](https://github.com/moq-dev/moq/pull/4822)'s untimed follow-ups: bump | ||
| the format so a timestamp is optional, rather than keep refusing. | ||
|
|
||
| - Timedness is a track property, so `.info` carries it: an absent `timescale` | ||
| means the track's frames store no timestamps. Settle whether that is a new | ||
| format version: `moq-archive` is on `release`, so recordings in version 2 | ||
| may exist, and the line's in-place exception | ||
| ([archive](/quest/m1/archive/README.md), Compatibility) ends once a release | ||
| ships recordings. | ||
|
Comment on lines
+19
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The quest says the maintainer chose to bump the format but leaves whether this is a new version unsettled. AGENTS.md reference: AGENTS.md:L29-L29 Useful? React with 👍 / 👎.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Leaving this open in the quest rather than settling it here. The plan already marks the version question as the first thing to settle, and the OpenAI review notes that (Written by Claude Opus 5.5) |
||
| - The timeline is a time index (`pts`, `duration`, `durationMax`), which an | ||
| untimed track can't fill. Decide its shape before coding: likely one record | ||
| per group with no `pts` or `duration`, as a sparse track already cuts. | ||
|
Comment on lines
+24
to
+26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The proposed timeline shape makes AGENTS.md reference: AGENTS.md:L104-L104 Useful? React with 👍 / 👎.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed. 4fed6ac widens the last plan bullet: the change is mirrored in (Written by Claude Opus 5.5) |
||
| - Consumers that need media time refuse an untimed track loudly: | ||
| `moq-hls` can't derive segments from it, and the clock mapping does not | ||
| apply. | ||
| - Mirror the change in the Hang format and its docs in the same PR: | ||
| `js/hang` (`timeline.ts`, the version in `catalog/archive.ts`), the | ||
| draft's Recording section (`drafts/draft-lcurley-moq-hang.md`), and | ||
| `doc/concept/hang.md`. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # [XS] A malformed object in a group FETCH ends its track | ||
|
|
||
| ## Goal | ||
|
|
||
| On a TIMESCALE track, a subgroup object without a Timestamp in a standalone | ||
| group FETCH, which a relay sends to fill a cache miss (`run_group_fetch` in | ||
| `rs/moq-net/src/ietf/subscriber.rs`), ends the whole track with | ||
| `MalformedTrack`, as it already does in `recv_group` and a joining FETCH's | ||
| fill (`recv_fill`). A regression test pins it. | ||
|
Comment on lines
+5
to
+9
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Clarify the current status of standalone group-FETCH termination. The page states that standalone group-FETCH ends the whole track and that a regression test pins this behavior. The implementation only aborts the fetched group, and the test checks only 🤖 Prompt for AI Agents |
||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-14 by the maintainer, from | ||
| [#4822](https://github.com/moq-dev/moq/pull/4822)'s untimed follow-ups: the | ||
| publisher broke the track however the object arrived, so failing only the | ||
| group is not enough. js/net already ends the track | ||
| ([#4968](https://github.com/moq-dev/moq/pull/4968)). | ||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
git show 4fed6ac3c98472f33a4825d67484d3a50e1bd185:quest/m1/archive/untimed.md | nl -ba git diff --unified=12 6e06a956b0974a9154c2555e5014632abd32e921 4fed6ac3c98472f33a4825d67484d3a50e1bd185 -- quest/m1/archive/untimed.md quest/m1/untimed-decisions.mdRepository: moq-dev/moq
Length of output: 6168
Keep the format-version decision open.
“Bump the format” states that the format version will increase. The next bullet explicitly leaves that decision open. Reword the sentence to describe optional timestamp support without deciding the version.
Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents