Repository navigation
fix(gst): anchor moqsink media to one wall clock #5554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kixelated
merged 6 commits into
main
from
quest/m1/3021-moq-gst-anchor-generated-media-timelines-to-wall-clock
Oct 15, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cbb2fd4
Claim GStreamer wall epoch quest
kixelated c7acd2a
Anchor moqsink media to one UTC epoch
kixelated 2d47331
Merge remote-tracking branch 'origin/main' into merge-5554
kixelated 0b617f7
refactor(gst): call the sink's running-time placement a wall clock
kixelated a31f3d9
Merge remote-tracking branch 'origin/main' into merge-5554
kixelated 3237b70
style(gst): format the wall-clock rename
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 0 additions & 35 deletions
35
quest/m1/3021-moq-gst-anchor-generated-media-timelines-to-wall-clock.md
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
🔎 Supported by static analysis
🏁 Script executed:
Repository: moq-dev/moq
Length of output: 6162
🏁 Script executed:
Repository: moq-dev/moq
Length of output: 25277
🌐 Web query:
official GStreamer documentation GstElement start_time current running time PAUSED preroll buffer forwarding💡 Result:
🏁 Script executed:
Repository: moq-dev/moq
Length of output: 15676
Do not anchor wall time from
start_time()during preroll.A preroll buffer reaches
forward_bufferthrough the sink pad’s chain function. Whencurrent_running_time()is unavailable and the buffer has no UNIX/NTP reference metadata, the fallback can anchor wall-clock zero at the preroll sample instead of at the laterPLAYINGstart. A pause ofNseconds beforePLAYINGcan therefore make the advertised wall timeNseconds early.Wall::placekeeps the first mapping for the run, so it does not self-correct.Do not use
start_time()as a substitute running-time sample. Treat this case as deferred placement. Preserve the buffer flow, keep the wall reservation pending, and retry placement on the first later buffer with a real running time. Do not simply setrunningtoNone:wall_zeroreturnspipeline has no running-time reference, andforward_bufferreports that error as a stream failure.The existing completion paths call
state.wall.finish(), so a run with no later buffer can release its unused reservation instead of leaving the catalog gate open indefinitely.🤖 Prompt for AI Agents