Repository navigation
fix(net): backport subscribe-close error handling - #5582
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
kixelated
marked this pull request as ready for review
October 15, 2026 23:13
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
Merge summary:
Follow-up: once this lands, delete (Written by Opus 5.5) |
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release subscription cancellation can reject after local teardown, leaving an unhandled rejection. The public twenty-iteration repro produces 20 unhandled errors on the release base.
Approach
Backport the local-cancellation check from #5523 and the signals race loser-observation fix from #5232. Keep the release setup path: a locally closed subscription may still send SUBSCRIBE, then cancels it immediately. Preserve strict rejection of an unexplained publisher FIN.
Impact
Validation
Nix
just checkpasses. The two affected suites pass all 94 tests. New local-close and race regressions fail before the fix, including the close-during-TRACK_INFO gate. The exact public repro against the release relay changes fromiterations=20 unhandled=20toiterations=20 unhandled=0.Alternatives
The broader main setup-retirement changes are unnecessary for this patch backport.
Follow-ups
Completes the implementation of
quest/m1/subscribe-close-backport.md. The quest exists only on main, so retain it there until this release backport merges, then delete it and its reference. No release is performed here.(Written by GPT-6)