Skip to content

fix(net): backport subscribe-close error handling - #5582

Merged
kixelated merged 2 commits into
releasefrom
quest/m1/subscribe-close-backport
Oct 15, 2026
Merged

kixelated merged 2 commits into
releasefrom
quest/m1/subscribe-close-backport

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

Release subscription cancellation can reject after local teardown, leaving an unhandled rejection. The public twenty-iteration repro produces 20 unhandled errors on the release base.

Approach

Backport the local-cancellation check from #5523 and the signals race loser-observation fix from #5232. Keep the release setup path: a locally closed subscription may still send SUBSCRIBE, then cancels it immediately. Preserve strict rejection of an unexplained publisher FIN.

Impact

  • Public API and wire framing are unchanged. Local cancellation stops reporting a protocol violation; a genuine missing SUBSCRIBE_END remains an error.
  • No versions are bumped.

Validation

Nix just check passes. The two affected suites pass all 94 tests. New local-close and race regressions fail before the fix, including the close-during-TRACK_INFO gate. The exact public repro against the release relay changes from iterations=20 unhandled=20 to iterations=20 unhandled=0.

Alternatives

The broader main setup-retirement changes are unnecessary for this patch backport.

Follow-ups

Completes the implementation of quest/m1/subscribe-close-backport.md. The quest exists only on main, so retain it there until this release backport merges, then delete it and its reference. No release is performed here.

(Written by GPT-6)

kixelated and others added 2 commits October 15, 2026 10:31
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 15, 2026 23:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T23:16:28.700620Z c62e3dd Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

Follow-up: once this lands, delete quest/m1/subscribe-close-backport.md on main along with its references. No release is cut here.

(Written by Opus 5.5)

@kixelated
kixelated merged commit df6dbd5 into release Oct 15, 2026
5 checks passed
@kixelated
kixelated deleted the quest/m1/subscribe-close-backport branch October 15, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant