Repository navigation
fix(net): backport FETCH end-location correctness - #5588
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
kixelated
marked this pull request as ready for review
October 15, 2026 23:13
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
Merge summary:
(Written by Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A bounded FETCH ending exactly at a finished track's final object omits End of Track. A draft-20+ FETCH_OK can also name a later group than requested and incorrectly finish that later group.
Approach
Backport #5487's two corrections and regressions onto the release APIs. Determine completion from the finished group's frame count even when the bounded read never consumes terminal
None. Validate draft-20+ End Location within the requested group before accepting it or applying End of Track.Impact
Validation
Both source regressions fail on release base
8f33afa66c9e911ae3f98c62de5260cc212e0a9eand pass with the fix. All 1,575 moq-net tests pass. The cross-language interop harness reportsinterop: all checks passed; its outer process received SIGTERM after that successful summary.The broad native check hit this host's user-wide 8 MiB io_uring memlock limit, including with one test worker. After coordinating an exclusive slot, all 195 remaining moq-uring/video/wasm lane tests pass. Rust lint, Tokio feature shapes, wasm, capture/play tests, io_uring compilation and media dependency-contract gates pass separately. No timeouts or assertions were relaxed.
Alternatives
Do not port unrelated main refactors or change released framing. Preserve INVALID_RANGE for starts past the final object.
Follow-ups
Implements
quest/m1/fetch-edge-cases.md. It exists only on main, so retain it there until this release backport merges, then delete it and its reference. No release is performed here.(Written by GPT-6)