Skip to content

fix(net): backport FETCH end-location correctness - #5588

Merged
kixelated merged 2 commits into
releasefrom
quest/m1/fetch-edge-cases
Oct 15, 2026
Merged

kixelated merged 2 commits into
releasefrom
quest/m1/fetch-edge-cases

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

A bounded FETCH ending exactly at a finished track's final object omits End of Track. A draft-20+ FETCH_OK can also name a later group than requested and incorrectly finish that later group.

Approach

Backport #5487's two corrections and regressions onto the release APIs. Determine completion from the finished group's frame count even when the bounded read never consumes terminal None. Validate draft-20+ End Location within the requested group before accepting it or applying End of Track.

Impact

  • Public API and wire framing are unchanged.
  • Final-object FETCH answers correctly report End of Track. Malformed draft-20 through draft-22 answers close with existing PROTOCOL_VIOLATION without changing track end state.
  • No versions are bumped.

Validation

Both source regressions fail on release base 8f33afa66c9e911ae3f98c62de5260cc212e0a9e and pass with the fix. All 1,575 moq-net tests pass. The cross-language interop harness reports interop: all checks passed; its outer process received SIGTERM after that successful summary.

The broad native check hit this host's user-wide 8 MiB io_uring memlock limit, including with one test worker. After coordinating an exclusive slot, all 195 remaining moq-uring/video/wasm lane tests pass. Rust lint, Tokio feature shapes, wasm, capture/play tests, io_uring compilation and media dependency-contract gates pass separately. No timeouts or assertions were relaxed.

Alternatives

Do not port unrelated main refactors or change released framing. Preserve INVALID_RANGE for starts past the final object.

Follow-ups

Implements quest/m1/fetch-edge-cases.md. It exists only on main, so retain it there until this release backport merges, then delete it and its reference. No release is performed here.

(Written by GPT-6)

kixelated and others added 2 commits October 15, 2026 10:27
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 15, 2026 23:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T23:15:37.348806Z cb71cd0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • No code changes from the merge pass. The diff mirrors fix(moq-net): validate FETCH ends and report final objects #5487's publisher and subscriber fixes and regression tests, adapted to release APIs (tokio clock, no properties field, no idle-track case).
  • Start-past-end INVALID_RANGE stays covered by the existing Finished case on release.
  • Codex reviewed cb71cd05 with no findings; all CI checks pass.
  • Auto-merge uses a merge commit, per CONTRIBUTING for release PRs.
  • Follow-up: delete quest/m1/fetch-edge-cases.md and its reference on main once this lands.

(Written by Opus 5.5)

@kixelated
kixelated merged commit 14b5a38 into release Oct 15, 2026
7 checks passed
@kixelated
kixelated deleted the quest/m1/fetch-edge-cases branch October 15, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant