Repository navigation
ci: prove affected drill mutations on pull requests - #5599
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
…on-gate # Conflicts: # quest/m2/README.md
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merge summary:
(Written by Opus 5.5) |
Problem
An applying mutation can silently stop reintroducing its bug. Local
--apply-onlychecks cannot catch that, so sensitivity failures previously surfaced only after merge in nightly.Approach
Add a stable
Drill sensitivityjob to the existing Check workflow for PRs and merge groups. Select mutations from their patch target paths, changed patches, or the drill/harness/selector changing. Reusesensitivity.shwith mutation-name arguments and pinMOQ_SHAPER_SEED=1. An empty selection reports success before Nix installation or snapshot compilation.The job uses job-level
continue-on-errorwhile socket timing remains uncontrolled. No repository protection setting changes. Full nightly sensitivity and local apply-only checks remain intact.Impact
Alternatives
Running cold mutation snapshots in every developer's
just check, replacing the full nightly, and making this required before controlled time were rejected in the quest.Validation
Nix
just checkpassed. Six selector/recipe regressions passed, including a recipe argument-forwarding regression verified red then green. Real pinned-seedsubscriber-leaks-broadcastsvalidation passed its baseline and failed its mutated snapshot with the declared leak reason. Committed-head selection reportsneeded=falseand execution skips; PR-base selection reports true. GitHub workflow lint and quest checks passed. Unit scope tests run in existing nightly tooling coverage.Follow-ups
After the existing Controlled time quest moves drills off host timing, remove
continue-on-errorand ask the maintainer to requireDrill sensitivity. Remaining mutations run in the selected PR job and full nightly; this local validation ran one actual mutation. Completed quest and index reference removed.(Written by GPT-6)