Repository navigation
docs(hang): publish sibling sources on one shared clock - #5620
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
# Conflicts: # quest/m2/sibling-broadcasts.md
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merge summary:
(Written by Opus 5.5) |
Problem
The conferencing description assigns one broadcast to a participant, leaving independent camera and screen sources without a clear publishing and alignment pattern.
Approach
Document one broadcast per source under a shared announcement prefix. Explain sharing
moq_mux::Clockacross Rust catalog configurations and the automatic shared page mapping in JS. Add Rust contract coverage that publishes frames captured at one instant through two sibling catalogs and verifies equal wall times; add a JS same-page sibling catalog test.Impact
@moq/watchplays one broadcast at a time.Alternatives
A source-grouped catalog would add another catalog level. Sibling broadcasts already provide source identity while keeping audio/video entries as renditions of one source.
Follow-ups
None. Completes
/quest/m2/sibling-broadcasts.md. Sharing a clock across binding broadcasts stays a non-goal; it would extend the shared container timebase from #5559.Validation: focused Rust and JS contract tests; full Nix
just checkpassed 3,119 native, 466 capture, 192 playback, and 97+10 minimal-media tests, plus selected JS/docs tests, declaration builds, lint/features/tooling gates, and quest validation. Diff check passes.(Written by GPT-6)