Skip to content

docs(hang): publish sibling sources on one shared clock - #5620

Merged
kixelated merged 3 commits into
mainfrom
quest/m2/sibling-broadcasts
Oct 16, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m2/sibling-broadcasts

Conversation

@kixelated

@kixelated kixelated commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The conferencing description assigns one broadcast to a participant, leaving independent camera and screen sources without a clear publishing and alignment pattern.

Approach

Document one broadcast per source under a shared announcement prefix. Explain sharing moq_mux::Clock across Rust catalog configurations and the automatic shared page mapping in JS. Add Rust contract coverage that publishes frames captured at one instant through two sibling catalogs and verifies equal wall times; add a JS same-page sibling catalog test.

Impact

  • No public API, wire-format, or catalog-format changes.
  • Document existing clock APIs and discovery behavior. Consumers align siblings; @moq/watch plays one broadcast at a time.

Alternatives

A source-grouped catalog would add another catalog level. Sibling broadcasts already provide source identity while keeping audio/video entries as renditions of one source.

Follow-ups

None. Completes /quest/m2/sibling-broadcasts.md. Sharing a clock across binding broadcasts stays a non-goal; it would extend the shared container timebase from #5559.

Validation: focused Rust and JS contract tests; full Nix just check passed 3,119 native, 466 capture, 192 playback, and 97+10 minimal-media tests, plus selected JS/docs tests, declaration builds, lint/features/tooling gates, and quest validation. Diff check passes.

(Written by GPT-6)

kixelated and others added 3 commits October 15, 2026 14:29
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
# Conflicts:
#	quest/m2/sibling-broadcasts.md
@kixelated
kixelated marked this pull request as ready for review October 15, 2026 23:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T23:47:47.437214Z 2542433 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cc091249-9bcc-49f7-87ea-a820be709cde
📥 Commits

Reviewing files that changed from the base of the PR and between 9f1f7d1 and 2542433.

📒 Files selected for processing: 6
  • doc/concept/hang.md
  • doc/concept/use-case/conferencing.md
  • js/publish/src/broadcast.test.ts
  • quest/m2/README.md
  • quest/m2/sibling-broadcasts.md
  • rs/moq-mux/src/catalog/producer.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Merged main; the only conflict was the quest file, which main had relinked after feat(ffi): share container source timebases #5559 completed the FFI timebase quest. Kept the deletion; no other references remain.
  • Updated the PR body's follow-up line, since the timebase quest it pointed at no longer exists.
  • Focused Rust test sibling_broadcasts_share_a_clock_and_capture_time passes on the merged head.
  • Codex reviewed the final head with no findings. No decisions were needed.

(Written by Opus 5.5)

@kixelated
kixelated enabled auto-merge October 15, 2026 23:56
@kixelated
kixelated added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit 1d305df Oct 16, 2026
14 checks passed
@kixelated
kixelated deleted the quest/m2/sibling-broadcasts branch October 16, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant