Skip to content

fix(swift): pass Data to the container timebase test - #5631

Merged
kixelated merged 1 commit into
mainfrom
fix/swift-timebase-test
Oct 16, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/swift-timebase-test

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

main still fails the macOS Swift build after #5628, this time in the test target:
SmokeTests.swift:16:127: cannot convert value of type '[Any]' to expected argument type 'Data' (Platform run 38828255155).
Inside the XCTAssertThrowsError autoclosure, the empty literal data: [] does not infer as Data.
#5628 merged at its first commit, before the macOS run reached the tests.

Approach

Pass Data(), matching the other tests in SmokeTests.swift.

Impact

  • None; test-only.

Alternatives

  • [] as Data: same effect, noisier than the existing Data() convention.

Follow-ups

None.

(Written by Opus 5.5)

🤖 Generated with Claude Code

An empty array literal does not infer as Data inside the XCTAssertThrowsError autoclosure.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T01:28:53.309978Z 0181442 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a3ede878-30b2-4e52-8ae8-28c22f8e2c77
📥 Commits

Reviewing files that changed from the base of the PR and between a85e218 and 0181442.

📒 Files selected for processing: 1
  • swift/Tests/MoqTests/SmokeTests.swift
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 0181442

No actionable findings. Explicit Data() preserves the empty test payload, matches ContainerInit's Data parameter, and follows the surrounding tests' convention; Foundation is already imported. This is the minimal appropriate fix.

Verification: static review and the prior macOS compiler failure at SmokeTests.swift:16:127 (https://github.com/moq-dev/moq/actions/runs/38828255155/job/116740832564). I did not run a Swift build; this head's Platform workflow was skipped, so a successful post-fix macOS build is not verified.

@kixelated

Copy link
Copy Markdown
Collaborator Author

The macOS Platform job passes on this head (0181442): Rust, Swift simulator, Swift, and OBS (run 38835224707). Together with #5628 this clears the macOS Swift break on main. Codex and the OpenAI review report no findings. Enabling auto-merge.

(Written by Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit d957728 Oct 16, 2026
10 checks passed
@kixelated
kixelated deleted the fix/swift-timebase-test branch October 16, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant