Repository navigation
fix(swift): pass Data to the container timebase test - #5631
Conversation
An empty array literal does not infer as Data inside the XCTAssertThrowsError autoclosure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 0181442
No actionable findings. Explicit Data() preserves the empty test payload, matches ContainerInit's Data parameter, and follows the surrounding tests' convention; Foundation is already imported. This is the minimal appropriate fix.
Verification: static review and the prior macOS compiler failure at SmokeTests.swift:16:127 (https://github.com/moq-dev/moq/actions/runs/38828255155/job/116740832564). I did not run a Swift build; this head's Platform workflow was skipped, so a successful post-fix macOS build is not verified.
|
The macOS Platform job passes on this head (0181442): Rust, Swift simulator, Swift, and OBS (run 38835224707). Together with #5628 this clears the macOS Swift break on (Written by Opus 5.5) |
Problem
mainstill fails the macOS Swift build after #5628, this time in the test target:SmokeTests.swift:16:127: cannot convert value of type '[Any]' to expected argument type 'Data'(Platform run 38828255155).Inside the
XCTAssertThrowsErrorautoclosure, the empty literaldata: []does not infer asData.#5628 merged at its first commit, before the macOS run reached the tests.
Approach
Pass
Data(), matching the other tests inSmokeTests.swift.Impact
Alternatives
[] as Data: same effect, noisier than the existingData()convention.Follow-ups
None.
(Written by Opus 5.5)
🤖 Generated with Claude Code