Repository navigation
test(browser): run media QA with alternate player engines - #5640
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Every engine now reads the player through the samples it logs, so the Chromium CDP read and the per-engine branches go away, and a navigation clears the previous document's sample. The Firefox player passes the full media run locally, so the quest is complete. Nightly drops its Chromium row, which interop.yml already runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…f8f2b9b8148 # Conflicts: # quest/m2/README.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merging at c116f19 with all three decisions accepted:
CI is green on this head and the Codex review found nothing. WebKit is unverified until its first nightly run. (Written by Claude Opus 5.5) |
Problem
Media QA exercised only Chromium and treated publisher capture/encode APIs as player requirements. A player on another engine needs its own capability check and explicit engine reporting.
Approach
just test media --media-engines chromium,firefox,webkitruns each requested player against a Chromium fixture. Firefox and WebKit players use the WebSocket fallback. The capability report names the engine version and lists missing publisher and player APIs separately, and fails by name instead of skipping. The lifecycle cases, shared tolerances, and five negative controls run unchanged per engine. Nightly runs Firefox and WebKit players (--with-deps); the Chromium player already runs ininterop.ymlon PRs and nightly.The player logs each sample to the console, and the harness reads player state only from those logs, for every engine. Any Playwright evaluation grants user activation and would invalidate the pre-gesture autoplay checks; Chromium avoided that with a CDP read, but Firefox and WebKit have no equivalent. One read path replaces the CDP player read and the per-engine branches. A navigation clears the previous document's sample so the matrix driver's reload cannot read stale state. The Chromium fixture is still read over CDP with
userGesture: false.Validation
just test media --media-engines chromium,firefoxlocally on the final code: all 12 rows PASS (media output + lifecycleand the five negative controls, per engine), including the gesture gate and capture permissions on the Firefox player. Firefox 155.0 lacks onlyMediaStreamTrackProcessor, so it can play this fixture but not publish it. An earlier Firefox run broke its leaked-session control at cold-start tone presence (71/79 against the 90% floor), the existing flake tracked byquest/m1/publish-audio-channel-count.md; it passed on the rerun and no tolerance changed.AudioContextdriven the wayGesture.unlockdoes it (resume()on pointerdown/pointerup) resumes in headless Firefox 155 with and without the autoplay-block prefs, and the full player run passes the gesture gate. Its cause is unconfirmed; this host has a working audio server.--with-deps; its first run is the first WebKit evidence. Playwright WebKit is not Safari.framenavigatedclear).just checkpasses.Decisions
Settled by the iterate agent with the recommended option; challenge any of them.
quest/m2/browser-media-qa-engines.md.interop.ymlnightly and on PRsImpact
--media-enginesonjust test media.Follow-ups
media.ts,probe.ts, andcontract.ts.🤖 Generated with Claude Code
(Written by GPT-6, iterated by Claude Opus 5.5)