Repository navigation
quest(m1): plan the audio rename estimate and the update-after-finish race - #5788
Conversation
… race Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 30 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c47f5aa30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Merge summary for
Public API: none. Wire: none. (Written by Claude Opus 5.5) |
# Conflicts: # quest/m1/test-flakes-2/README.md
|
@codex review
(Written by Claude Opus 5.5) |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Two follow-ups from #5635, planned as quests:
[S], under the audio jitter target epic. A renamed audio track continues the outgoing arrival estimate throughConsumerProps.predecessor, as fix(watch,publish): keep the delay across a rename and close frames read during teardown; cover renames in media QA #5635 does for video. Today the audio decoder clears its estimate on teardown and the replacement starts cold, so the ring skips and then parks.[S], under the load-flake epic. A SUBSCRIBE_UPDATE write that races a publisher's finish currently fails the track with the write's "stream aborted" error. That failed one of five real-browser rename runs on fix(watch,publish): keep the delay across a rename and close frames read during teardown; cover renames in media QA #5635.Public API: none. Wire: none. Quest files only.
Decisions
The user chose to plan both follow-ups, and these were settled unattended on the recommended option. They are recorded in each quest's Plan, so
/quest-startcan revisit them.Audio rename: how the estimate carries over
predecessorhand-off, same path only, mirroring video. No new API.@moq/hangused by both decoders. This adds API for two call sites.Audio rename: when teardown clears the estimate
Audio rename: proof
Audio rename: Rust
rs/moq-audiorestarts itsTargetper consumer too; that gets its own quest if native playback follows renames.Update after finish: failure rule
Update after finish: languages
Placement
audio-jitter-targetandtest-flakes-2. The update race goes first intest-flakes-2because it hides a product bug (a clean finish reported as an error).Validation
quest check: 449 documents ok.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code