Skip to content

quest(m1): plan the audio rename estimate and the update-after-finish race - #5788

Merged
kixelated merged 3 commits into
mainfrom
plan/rename-follow-ups
Oct 17, 2026
Merged

kixelated merged 3 commits into
mainfrom
plan/rename-follow-ups

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Two follow-ups from #5635, planned as quests:

Public API: none. Wire: none. Quest files only.

Decisions

The user chose to plan both follow-ups, and these were settled unattended on the recommended option. They are recorded in each quest's Plan, so /quest-start can revisit them.

Audio rename: how the estimate carries over

  • ✅ predecessor hand-off, same path only, mirroring video. No new API.
  • A shared hand-off helper in @moq/hang used by both decoders. This adds API for two call sites.

Audio rename: when teardown clears the estimate

  • ✅ Only when no replacement follows (disabled, muted, rendition removed), so the target never falls out during a rename.
  • Always clear on teardown, as today. The target dips at every rename.

Audio rename: proof

  • ✅ A mocked-clock unit test (rename keeps the delay; another path does not inherit).
  • Also a real-browser audio-rename media case. The fixture would need a second audio codec configuration.

Audio rename: Rust

  • ✅ Out of scope. rs/moq-audio restarts its Target per consumer too; that gets its own quest if native playback follows renames.
  • Include Rust parity here.

Update after finish: failure rule

  • ✅ A failed update write defers to the subscribe stream's own outcome: a clean finish ends the track cleanly, and a reset's error wins.
  • Ignore update write errors entirely. This hides a real reset until the responses notice it.
  • Retry the write. This is pointless against a stream the peer stopped reading.

Update after finish: languages

  • ✅ JS and Rust together. Rust's serve loop hands the track back with the flush error, so it likely shares the race.
  • JS only, where it was observed.

Placement

  • ✅ Each quest under the epic it belongs to: audio-jitter-target and test-flakes-2. The update race goes first in test-flakes-2 because it hides a product bug (a clean finish reported as an error).
  • New top-level m1 quests.

Validation

quest check: 449 documents ok.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

… race

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0ab4ff55-f69d-4a31-812b-c61e6473bea0
📥 Commits

Reviewing files that changed from the base of the PR and between 8297ce7 and 884949d.

📒 Files selected for processing: 4
  • quest/m1/audio-jitter-target/README.md
  • quest/m1/audio-jitter-target/audio-rename.md
  • quest/m1/test-flakes-2/README.md
  • quest/m1/test-flakes-2/update-after-finish.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T00:56:08.852137Z 884949d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c47f5aa30

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

@codex review

aa9b3361d makes the audio rename quest's dependency on #5635 explicit.

(Written by Claude Opus 5.5)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: aa9b3361db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary for aa9b3361d:

Public API: none. Wire: none.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 17, 2026
# Conflicts:
#	quest/m1/test-flakes-2/README.md
@kixelated

Copy link
Copy Markdown
Collaborator Author

@codex review

884949d46 merges main after the queue removed this PR for a conflict. In test-flakes-2/README.md, main had finished the interop close-code quest and added two others; this keeps main's list with the new entry first. With #5635 merged, the audio rename quest's dependency note is now in the past tense.

(Written by Claude Opus 5.5)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 884949d461

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kixelated
kixelated enabled auto-merge October 17, 2026 00:56
@kixelated
kixelated added this pull request to the merge queue Oct 17, 2026
Merged via the queue into main with commit 2281d20 Oct 17, 2026
6 checks passed
@kixelated
kixelated deleted the plan/rename-follow-ups branch October 17, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant