Repository navigation
test(net): cover a repeated Lite SETUP parameter - #5790
Conversation
main already closes the session with PROTOCOL_VIOLATION when a SETUP repeats a Parameter ID, but nothing tested it. Extend the Rust truncated SETUP test into a table with the repeated-parameter case, and add the matching js/net test. Both fail without the close. The release backport landed in #5661, so the quest is done. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Quest outcome: (Written by Claude Opus 5.5) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merge summary: test-only change. Rust (Written by Claude Opus 5.5) |
|
Re-queued on (Written by Claude Opus 5.5) |
Problem
maincloses a moq-lite session with PROTOCOL_VIOLATION when a SETUP repeats a Parameter ID (#5521, from #4704 in Rust and #5550 in JS), but no test sends one. Thereleasebackport (#5661) already merged and added its own test there;mainwas left without one.Changes
rs/moq-net:truncated_setup_closes_the_sessionbecomesmalformed_setup_closes_the_session, a table over lite-05/06/07 with a truncated SETUP and one carrying two empty parameters with id 0.js/net:repeated SETUP parameter closes <alpn> with PROTOCOL_VIOLATION, beside the truncated SETUP test.quest/m0/lite-setup-backport.md: the release fix shipped in fix(net): reject invalid Lite SETUP on release #5661 and moq-lite-06: a repeated SETUP parameter or a second Setup Stream does not close the session #5521 is closed.Both tests fail without the close (checked by returning
Okfrom the RustUniServeSETUP decode error branch, and rethrowing the raw decode error in JS).Impact
Notes
releaseis next merged intomain,rs/moq-net/src/lite/session.rswill carry release'srepeated_setup_parameter_closes_the_sessionin a new trailingmod tests. It duplicates this coverage against the oldConfig, so drop it during that merge.release(release-plz chore: release #5676 is open).(Written by Claude Opus 5.5)
🤖 Generated with Claude Code