Skip to content

test(net): cover a repeated Lite SETUP parameter - #5790

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/lite-setup-backport
Oct 17, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/lite-setup-backport

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

main closes a moq-lite session with PROTOCOL_VIOLATION when a SETUP repeats a Parameter ID (#5521, from #4704 in Rust and #5550 in JS), but no test sends one. The release backport (#5661) already merged and added its own test there; main was left without one.

Changes

Both tests fail without the close (checked by returning Ok from the Rust UniServe SETUP decode error branch, and rethrowing the raw decode error in JS).

Impact

  • Public API: none.
  • Wire: none.

Notes

  • When release is next merged into main, rs/moq-net/src/lite/session.rs will carry release's repeated_setup_parameter_closes_the_session in a new trailing mod tests. It duplicates this coverage against the old Config, so drop it during that merge.
  • The quest's smoke rows L06-7-3-MUST-112 and L06-6-3-1-MUST-092 pass once the next 0.14.x / moq-net 0.3.x patch is cut from release (release-plz chore: release #5676 is open).

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

kixelated and others added 2 commits October 16, 2026 16:15
main already closes the session with PROTOCOL_VIOLATION when a SETUP
repeats a Parameter ID, but nothing tested it. Extend the Rust truncated
SETUP test into a table with the repeated-parameter case, and add the
matching js/net test. Both fail without the close.

The release backport landed in #5661, so the quest is done.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Quest outcome: quest/m0/lite-setup-backport.md is complete. The release half landed earlier in #5661; this PR adds the repeated-Parameter-ID regression test on main in both Rust and JS (js/net already closed on it), verified to fail without the close, and deletes the quest. No open decisions.

(Written by Claude Opus 5.5)

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f61aaf2-e440-4f79-995f-6259f23a8597
📥 Commits

Reviewing files that changed from the base of the PR and between b7d7e99 and 90fa44a.

📒 Files selected for processing: 4
  • js/net/src/lite/connection.test.ts
  • quest/m0/README.md
  • quest/m0/lite-setup-backport.md
  • rs/moq-net/src/lite/session.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T00:36:59.909680Z 90fa44a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: test-only change. Rust malformed_setup_closes_the_session now covers a truncated SETUP and a SETUP repeating Parameter ID 0 over lite-05/06/07; JS adds the matching repeated-parameter test per ALPN. quest/m0/lite-setup-backport.md is deleted since the release half landed in #5661. Codex reviewed head 3f49098 with no findings; no open decisions. Enabling auto-merge on that head.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge October 16, 2026 23:29
@kixelated
kixelated added this pull request to the merge queue Oct 16, 2026
@kixelated
kixelated removed this pull request from the merge queue due to a manual request Oct 17, 2026
@kixelated
kixelated enabled auto-merge October 17, 2026 00:50
@kixelated

Copy link
Copy Markdown
Collaborator Author

Re-queued on 90fa44a2c: the first queue entry could not build because quest/m0/README.md conflicted with main (main added the refusal-close quests and dropped the Kotlin POM one). The merge from main keeps main's list without the Lite SETUP line; no code changed.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 17, 2026
Merged via the queue into main with commit 7c38c43 Oct 17, 2026
13 checks passed
@kixelated
kixelated deleted the quest/m0/lite-setup-backport branch October 17, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant