Repository navigation
feat(quic)!: report acknowledged send-stream offsets, replacing Checkpoint with offsets #5817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9c397c1
quest(m2): claim quic-ack-progress
kixelated 7ec8d9d
feat(quic): report when a checkpoint's data is acknowledged
kixelated 112d157
Merge branch 'main' of github.com:moq-dev/moq into quest/m2/quic-ack-…
kixelated 6981441
Merge branch 'main' of github.com:moq-dev/moq into quest/m2/quic-ack-…
kixelated ede4d62
docs(quic): migration notes and a checkpoint benchmark
kixelated 4a1d706
fix(quic): checkpoint instants on reordered ACKs and empty resets
kixelated a867b46
fix(quic): fail checkpoints taken on a stopped or reset stream
kixelated 3da6169
fix(quic): prune dropped checkpoints when taking another
kixelated 98e6cae
fix(quic): subtract the ACK delay only for the largest packet
kixelated 6fc2259
fix(quic): cap the ACK delay after confirming ACK_FREQUENCY
kixelated 64a299b
Merge branch 'main' of github.com:moq-dev/moq into quest/m2/quic-ack-…
kixelated 589321f
Merge remote-tracking branch 'origin/main' into HEAD
kixelated 02826de
fix(quic): resolve a checkpoint at the latest ACK instant below it
kixelated b54745d
fix(quic): sweep checkpoints replaced before they drop
kixelated 663cea6
fix(quic): time only the bytes an ACK newly covers
kixelated 3a27124
test(quic): a redundant ACK leaves a checkpoint's instant alone
kixelated 00a43a5
docs(quic): list ACK checkpoints as a carried change
kixelated 77cb57d
refactor(quic): make a checkpoint plain data, registering a waiter on…
kixelated 0653c1e
Merge remote-tracking branch 'origin/main' into quest/m2/quic-ack-pro…
kixelated e2a4a02
refactor(quic)!: replace Checkpoint with byte offsets on SendStream
kixelated be05f32
Merge remote-tracking branch 'origin/main' into quest/m2/quic-ack-pro…
kixelated bfc9223
fix(quic): report a waiting offset that a reset or STOP_SENDING fails
kixelated f58a1c5
fix(quic): wake every acked waiter on a reset or STOP_SENDING
kixelated c588775
docs(quic): say what SendStream::offset reports after a reset
kixelated 2794e60
docs(quic): format the ACK progress notes
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This migration entry covers only the new
StreamEvent::Acked, but the same commit removes the publicCheckpointtype andSendStream::checkpointfrom both moq-quic and moq-tokio and replaces their reset flow with byte offsets andreset_at; existing consumers therefore stop compiling without any documented replacement, and moq-tokio'sMIGRATE.mdis not updated at all. Add before/after guidance to every affected package's migration file.AGENTS.md reference: AGENTS.md:L60-L62
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining:
CheckpointandSendStream::checkpointcame in with #5690, which no release contains yet (it is not onrelease), so no released consumer breaks. moq-quic's MIGRATE.md lists changes from quinn-proto, which has neither, and moq-tokio's lists changes since its last release. TheStreamEvent::Ackedentry is the one break that applies.(Written by Opus 5.5)