Repository navigation
test(ts): judge the export on a congested path, not random loss - #5918
Conversation
`just test ts` gains --rate and --queue: moq-shaper's token bucket on the subscriber's leg behind a 2 s queue. Under --rate the export must stay T-STD compliant and continuous, shed only whole groups (holes.py --shed, matched by PTS), and still deliver the last group. The nightly --hrd and --passthrough lossy steps move to --rate 7000000; --loss stays for correctness. The relay drills, moq-quic's sim and BBR3's unit tests prove correctness and keep their random loss. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Outcome: the harness work is done. The PR stays a draft on one open decision, queue depth vs "the queue must overflow" (see the body). BBRv3 keeps about one RTT queued, so only a queue about 50 ms deep overflows reliably. I recommend keeping the 2 s queue with "the export shed media" as the activation check (option A). Option B is (Written by Claude Opus 5.5) |
|
Orchestrator decision, made under the user's overnight delegation to settle iterate decisions with the recommended option. It is open to challenge. Queue depth: Option A. Nightly keeps the deep 2 s queue (twice the export's delay), and the activation check is "the export shed media", not "the queue overflowed". Why: AGENTS.md asks for a rate limit below the media bitrate behind a deep but finite queue. Under BBRv3 a deep queue does not overflow, since it keeps about a round trip queued, so requiring overflow would force a queue too shallow (about 50 ms) to show latency growing with it. With 2 s the latency oracle stays meaningful: CUBIC fills the queue and fails the run, BBR does not and passes. The per-drill calls in the description also stand: every relay drill proves correctness, so the impaired lane keeps its 5% random loss. That changes only if review shows a drill judges behavior. (Written by Claude Opus 5.5) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review (Written by Claude Opus 5.5) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11f4bc70da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # .github/workflows/ts.yml
holes.py --shed graded the captured PTS as a set, so a capture that reordered or repeated frames passed. Match the capture as an ordered subsequence of the source's decode-order PTS instead, and fail any frame past the last one that continues the source's order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9834620458
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BBRv3 never fills a queue deeper than about 1.5 round trips (100 ms overflowed in 3 of 6 runs, 150 ms and deeper never), so the 2 s congested lane covers relay shedding but no tail drop. The new lane runs the relay's loss-based CUBIC behind a 250 ms queue (five round trips), which overflowed 423-430 datagrams in each of four 120 s runs while every grader passed, and fails a loss-based run whose queue never overflowed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 037b250ff1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review (Written by Claude Opus 5.5) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 037b250ff1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… tail under --loss-ok holes.py --shed now counts frames a capture skipped before its first kept one against that group, so a capture opening mid-GOP fails as resuming mid-group. passthrough.py --loss-ok still reports internal gaps but fails a capture that ends before the source's last packet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review (Written by Claude Opus 5.5) |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Quest:
quest/m1/bufferbloat.md(deleted here).Summary
just test tsgains--rate <bits/s>and--queue <duration>(default 2 s), passed tomoq-shaper's token bucket on the relay -> subscriber leg (25 ms each way, 1500 B burst).--lossstays for correctness runs, and the two can combine.--ratethe oracle is the one the quest set:compliance.py,pcr-timing.pyand PCR accuracy gate as on a clean path.holes.py --shedmatches the capture's frames to the source's by PTS. Of each source group the capture keeps a decode-order prefix and never resumes mid-group.decode.pyis skipped and--open-gopis refused, since both owe every unit. Passthrough runspassthrough.py --loss-ok.media skipped upstreamormissed its deadlinein its log), so a rate above the media rate fails loud.ts.yml:--hrd --loss 1becomes--hrd --rate 7000000(below its 9 Mb/s video), and--passthrough --loss 1becomes--passthrough --rate 7000000(below its 10 Mb/s multiplex).test/ts/README.md: the lossy-path section is now "Impaired path", with congested (--rate) and lossy (--loss, correctness only) subsections and the measurements below. The old random-loss ceiling table is gone; the random-loss audit re-judges what it drove.test/drill/README.mdand theimpairment()doc indrills.rssay the drills prove correctness, so they keep random loss.Why
holes.py --shedmatches by PTS: hang carries no DTS, so the export derives each picture's DTS. When a group is cut after a P picture, that picture's DTS moves (source 352800, export 363600). A DTS-step check misreads that as a mid-group resume.Public API: none. Wire: none.
Measurements (2026-10-18, shared host)
--hrd --rate 7000000--hrd --rate 7000000--hrd --rate 7000000--hrd --rate 7000000--hrd --rate 7000000 --live--passthrough --rate 7000000--hrd --rate 7000000, CUBIC (MOQ_QUIC_CONGESTION_CONTROL=loss)The CUBIC row is the negative control: a sender that fills the queue fails the run.
--loss 1and a clean default run still pass.Decisions
1. Queue depth vs "the queue must overflow". The quest asks for a deep queue that overflows. Under the default BBRv3 those can't both hold: it keeps about one RTT queued (inflight about 2x BDP), so only a queue about one RTT deep (50 ms here) overflows reliably. 100 ms overflows intermittently, and 150 ms or deeper never does. The backlog lands at the relay instead, which evicts stale groups (
Old).--queue 50msin nightly, with "the shaper overflowed" as the activation check. Congestion drops then happen every run, but a 50 ms queue can't show latency growing with it.Settled as A by the orchestrating session under the user's overnight delegation, open to challenge (comment). The per-drill calls below stand on the same basis.
Calls I made (please review)
cancel_under_backpressure_releases_the_reader: correctness (resources released, a rejoin is served). Keeps the 5% loss.relay_killed_mid_group_aborts_then_resumes: correctness (abort surfaces, the same handles resume). Keeps.interrupted_publisher_republishes_new_content: correctness (withdrawal, new content served). Keeps.bursts_cross_a_cluster/_flapping_peer/_transport_peer: correctness. Every group is recovered live or by FETCH, the route returns, and IETF FETCH is served. The 10 sSETTLEis a stall bound (a third of Cross-node routing on cdn.moq.pro loses groups, stalls tracks and keeps closed broadcasts announced under bursty control traffic (A/B/C repro inside) #4349's 30 s), not a latency target. They already run a 100 kbit/s, 50 ms bottleneck that must overflow. Their random loss drops theMAX_STREAMS/MAX_DATAframes the credit waits exercise. Keep.no_publisher_never_delivers: negative control. Keeps.--rate: compliance stays report-only (--loss-ok), since verbatim packets keep their continuity counters across a gap. 59 of 60 gaps resumed on a video RAP. One near the source's end resumed on a non-PUSI packet.--lossstep remains.--lossis manual and correctness-only.Checks
just check: the JS module fails on main's wasm-bindgen 0.2.127 vs Nix CLI 0.2.129 mismatch, which fix(rs): match wasm-bindgen to the nix dev shell's 0.2.129 CLI #5911 fixes. Every other selected module passes: rs check-test for moq-relay, quest, drill-sensitivity--apply-only, markdown, shell, toml, gh, andholes.test.py.ts.ymlpath-filter comment and a neighboring line ofgrader-determinism.md, so whichever lands second resolves a small conflict.Follow-ups
export ts --passthroughshould signal a discontinuity across a gap, or accept CC errors. Also investigate the end-of-stream gap that resumed mid-PES.--ratearm of--livein nightly would grade end-to-end latency directly; it passed locally.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)